Bug 156810

Summary: Modern IDB (Workers): Introduce "IDBConnectionProxy" for future threading abstraction, and adopt it in IDBFactory
Product: WebKit Reporter: Brady Eidson <beidson>
Component: WebCore Misc.Assignee: Brady Eidson <beidson>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 149117, 149953    
Attachments:
Description Flags
Patch v1 achristensen: review+

Brady Eidson
Reported 2016-04-20 14:47:26 PDT
Modern IDB (Workers): Introduce "IDBConnectionProxy" for future threading abstraction You can get to your IDBConnectionProxy from your ScriptExecutionContext, which will work on both main and worker threads. IDBConnectionProxy will hold on to the IDBConnectionToServer, which will remain a main-thread-only construct. Slowly, IDB* objects getting to their IDBConnectionProxy will replace them holding on to an IDBConnectionToServer directly.
Attachments
Patch v1 (39.47 KB, patch)
2016-04-20 15:06 PDT, Brady Eidson 		achristensen: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brady Eidson
Comment 1 2016-04-20 14:48:55 PDT
While I'm touching IDBFactory, I'm going to modernize it a bit by replacing ExceptionCode with ExceptionCodeWithMessage.
Brady Eidson
Comment 2 2016-04-20 15:06:37 PDT
Created attachment 276856 [details] Patch v1
Brady Eidson
Comment 3 2016-04-20 15:33:03 PDT
Seems to have recked havoc on mac-wk2 tests (of course everything works great locally *sigh*) Will fix before landing.
Brady Eidson
Comment 4 2016-04-20 16:40:40 PDT
NM! Things are fine. Yay.
Brady Eidson
Comment 5 2016-04-20 16:46:23 PDT
http://trac.webkit.org/changeset/199797
Note You need to log in before you can comment on or make changes to this bug.