Bug 15681

Summary:

Add a new JSGlobalObject class and make Interpreter (and Context) use it

Product:

WebKit

Reporter:

Eric Seidel (no email) <eric>

Component:

JavaScriptCore

Assignee:

Eric Seidel (no email) <eric>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

523.x (Safari 3)

Hardware:

Mac

OS:

OS X 10.4

Attachments:

Description	Flags
a first stab (using templates, ick)	none
full patch (minus changelog), 0.5% on SunSpider	none
full patch, 0.5% speedup on SunSpider	mjs: review+

Eric Seidel (no email)

Reported 2007-10-24 20:29:59 PDT

Add a new JSGlobalObject class and make Interpreter (and Context) use it So I have a partial patch. Not quite done because I ran into trouble with: JSGlobalContextRef JSGlobalContextCreate(JSClassRef globalObjectClass) which expects to be able to make a JSCallbackObject and pass that off as the global object. I might have to make JSGlobalObject an interface instead of a class. (That would also make things nicer for Window, which wants to inherit from DOMObject.)

Attachments
a first stab (using templates, ick) (63.86 KB, patch) 2007-10-24 21:45 PDT, Eric Seidel (no email)	no flags	Details Formatted Diff Diff
full patch (minus changelog), 0.5% on SunSpider (89.97 KB, patch) 2007-10-24 22:33 PDT, Eric Seidel (no email)	no flags	Details Formatted Diff Diff
full patch, 0.5% speedup on SunSpider (93.96 KB, patch) 2007-10-24 22:45 PDT, Eric Seidel (no email)	mjs: review+	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Eric Seidel (no email)

Comment 1 2007-10-24 21:45:06 PDT

Created attachment 16851 [details] a first stab (using templates, ick)

Eric Seidel (no email)

Comment 2 2007-10-24 22:33:08 PDT

Created attachment 16852 [details] full patch (minus changelog), 0.5% on SunSpider

Eric Seidel (no email)

Comment 3 2007-10-24 22:45:25 PDT

Created attachment 16853 [details] full patch, 0.5% speedup on SunSpider

Eric Seidel (no email)

Comment 4 2007-10-24 23:05:47 PDT

Actually, turns out this is 0.8% faster.

Maciej Stachowiak

Comment 5 2007-10-24 23:19:41 PDT

Comment on attachment 16853 [details] full patch, 0.5% speedup on SunSpider r=me

Maciej Stachowiak

Comment 6 2007-10-24 23:20:05 PDT

(assuming tests pass)

Eric Seidel (no email)

Comment 7 2007-10-24 23:49:17 PDT

Landed as r27022.

Note You need to log in before you can comment on or make changes to this bug.