Bug 156802

Summary: Unindent an unnecessary block in stringProtoFuncSplitFast().
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, keith_miller, msaboff, saam
Priority: P2    
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch. fpizlo: review+

Mark Lam
Reported 2016-04-20 11:48:53 PDT
In webkit.org/b/156013, I refactored stringProtoFunc into stringProtoFuncSplit. In that patch, I left an unnecessary block of code in its original block (with FIXMEs) to keep the diff for that patch minimal. Now that the patch for webkit.org/b/156013 has landed, I will unindent that block and remove the FIXMEs.
Attachments
proposed patch. (8.95 KB, patch)
2016-04-20 11:55 PDT, Mark Lam 		fpizlo: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Lam
Comment 1 2016-04-20 11:50:35 PDT
(In reply to comment #0) > In webkit.org/b/156013, I refactored stringProtoFunc into > stringProtoFuncSplit. In that patch, I left an unnecessary block of code in > its original block (with FIXMEs) to keep the diff for that patch minimal. > Now that the patch for webkit.org/b/156013 has landed, I will unindent that > block and remove the FIXMEs. typo: /stringProtoFunc/stringProtoFuncSplit/ and /stringProtoFuncSplit/stringProtoFuncSplitFast/.
Mark Lam
Comment 2 2016-04-20 11:55:41 PDT
Created attachment 276838 [details] proposed patch.
Mark Lam
Comment 3 2016-04-20 12:11:22 PDT
Landed in r199780: <http://trac.webkit.org/r199780>.
Darin Adler
Comment 4 2016-04-22 11:36:09 PDT
Comment on attachment 276838 [details] proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=276838&action=review > Source/JavaScriptCore/runtime/StringPrototype.cpp:1191 > + String separator = separatorValue.toString(exec)->value(exec); Seems we should always use toWTFString instead of writing it out like this.
Note You need to log in before you can comment on or make changes to this bug.