Bug 156787

Summary: [GTK] Move GTK+-independent platform code to platform/glib
Product: WebKit Reporter: Claudio Saavedra <csaavedra>
Component: WebKitGTKAssignee: Claudio Saavedra <csaavedra>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, commit-queue
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Claudio Saavedra
Reported 2016-04-20 01:47:05 PDT
[GTK] Move GTK+-independent platform code to platform/glib
Attachments
Patch (81.29 KB, patch)
2016-04-20 01:58 PDT, Claudio Saavedra 		no flags
DetailsFormatted DiffDiff
Patch (49.40 KB, patch)
2016-04-20 04:34 PDT, Claudio Saavedra 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Claudio Saavedra
Comment 1 2016-04-20 01:58:42 PDT
Created attachment 276813 [details] Patch
WebKit Commit Bot
Comment 2 2016-04-20 01:59:42 PDT
Attachment 276813 [details] did not pass style-queue: ERROR: Source/WebCore/platform/glib/SharedBufferGlib.cpp:25: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/glib/LanguageGlib.cpp:27: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 2 in 21 files If any of these errors are false positives, please file a bug against check-webkit-style.
Carlos Garcia Campos
Comment 3 2016-04-20 02:21:51 PDT
Comment on attachment 276813 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=276813&action=review > Source/WebCore/platform/glib/ErrorsGlib.h:21 > +#define ErrorsGlib_h I'm not sure about this particular rename. This is not the glib implementation of anything, but the error messages used by the GTK port. In this case the Gtk in the name didn't refer to the GTk library, but the GTK port. I know it's confusing, but I think ErrorsGlib is more confusing. > Source/WebCore/platform/glib/LanguageGlib.cpp:57 > +Vector<String> platformUserPreferredLanguages() Something similar applies here. This is the implementation for the GTK+ port, nothing depends on GLib here. > Source/WebCore/platform/glib/LoggingGlib.cpp:33 > +String logLevelString() Ditto.
Claudio Saavedra
Comment 4 2016-04-20 04:34:10 PDT
Created attachment 276816 [details] Patch
WebKit Commit Bot
Comment 5 2016-04-20 04:35:00 PDT
Attachment 276816 [details] did not pass style-queue: ERROR: Source/WebCore/platform/glib/SharedBufferGlib.cpp:25: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Commit Bot
Comment 6 2016-04-20 08:02:49 PDT
Comment on attachment 276816 [details] Patch Clearing flags on attachment: 276816 Committed r199772: <http://trac.webkit.org/changeset/199772>
WebKit Commit Bot
Comment 7 2016-04-20 08:02:54 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.