Bug 156755

Summary: Update ANGLE
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: ANGLEAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, graouts, jeremyhu
Priority: P2    
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 156789    
Bug Blocks:    
Attachments:
Description Flags
patch dino: review+

Alex Christensen
Reported 2016-04-19 11:59:35 PDT
Let's update ANGLE.
Attachments
patch (6.93 MB, patch)
2016-04-19 12:02 PDT, Alex Christensen 		dino: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2016-04-19 12:02:04 PDT
Created attachment 276741 [details] patch
Alex Christensen
Comment 2 2016-04-19 12:07:31 PDT
This regresses webgl/1.0.2/conformance/glsl/reserved/webgl_preprocessor_reserved.html but everything else passes. I think looking into that after this lands is probably the best way to go.
Alex Christensen
Comment 3 2016-04-19 12:14:28 PDT
That test was removed in https://github.com/KhronosGroup/WebGL/pull/1230 I think I'll remove it, too.
Dean Jackson
Comment 4 2016-04-19 12:14:54 PDT
Looking at the patch offline.
Dean Jackson
Comment 5 2016-04-19 12:24:40 PDT
Comment on attachment 276741 [details] patch I checked that Alex updated the .plist file we use for our Open Source contributions, and that he kept the legal note about how we're distributing the generated source.
Alex Christensen
Comment 6 2016-04-19 12:46:47 PDT
http://trac.webkit.org/changeset/199738
Antoine Quint
Comment 7 2016-04-20 07:42:03 PDT
This caused LayoutTests/compositing/webgl/webgl-reflection.html to regress on the iOS Simulator bot. See https://build.webkit.org/results/Apple%20iOS%209%20Simulator%20Release%20WK2%20(Tests)/r199771%20(4996)/compositing/webgl/webgl-reflection-pretty-diff.html.
Jeremy Huddleston Sequoia
Comment 8 2016-04-29 09:42:07 PDT
This change also causes the gtk build to fail. This can be seen by the red in the attachments field. Why was this pushed given the known fallout? https://bugs.webkit.org/show_bug.cgi?id=157182
Note You need to log in before you can comment on or make changes to this bug.