| Summary: | Update ANGLE | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alex Christensen <achristensen> | ||||
| Component: | ANGLE | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | dino, graouts, jeremyhu | ||||
| Priority: | P2 | ||||||
| Version: | WebKit Local Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | 156789 | ||||||
| Bug Blocks: | |||||||
| Attachments: |
|
||||||
|
Description
Alex Christensen
2016-04-19 11:59:35 PDT
Created attachment 276741 [details]
patch
This regresses webgl/1.0.2/conformance/glsl/reserved/webgl_preprocessor_reserved.html but everything else passes. I think looking into that after this lands is probably the best way to go. That test was removed in https://github.com/KhronosGroup/WebGL/pull/1230 I think I'll remove it, too. Looking at the patch offline. Comment on attachment 276741 [details]
patch
I checked that Alex updated the .plist file we use for our Open Source contributions, and that he kept the legal note about how we're distributing the generated source.
This caused LayoutTests/compositing/webgl/webgl-reflection.html to regress on the iOS Simulator bot. See https://build.webkit.org/results/Apple%20iOS%209%20Simulator%20Release%20WK2%20(Tests)/r199771%20(4996)/compositing/webgl/webgl-reflection-pretty-diff.html. This change also causes the gtk build to fail. This can be seen by the red in the attachments field. Why was this pushed given the known fallout? https://bugs.webkit.org/show_bug.cgi?id=157182 |