Bug 156749
| Summary: | Paths returned by fileSystemRepresentation are not consistently checked for Null strings | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Brent Fulgham <bfulgham> |
| Component: | WebCore Misc. | Assignee: | Brent Fulgham <bfulgham> |
| Status: | RESOLVED INVALID | ||
| Severity: | Normal | CC: | bfulgham, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | All | ||
| OS: | All | ||
Brent Fulgham
Our FileSystem::fileSystemRepresentation method returns CString() under various error conditions. In most cases, we check for a null return of this method before passing the result on to functions (primarily POSIX routines) that are specified as crashing (or undefined behavior) if given a NULL input.
We need to be consistent about checking this return value.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/25807632>
Brent Fulgham
I did a search for instances of 'fileSystemRepresentation', and found that all cases except for SandboxExtension::createHandle were safe.
The various POSIX functions called with the result of this function handle null inputs properly.
Brent Fulgham
No changes needed here. A fix for SandboxExtension::createHandle will be landed soon.