Bug 156734

Summary: bmalloc: Merge the large and xlarge allocators
Product: WebKit Reporter: Geoffrey Garen <ggaren>
Component: bmallocAssignee: Geoffrey Garen <ggaren>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, commit-queue, ggaren, kling, msaboff, sam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Geoffrey Garen
Reported 2016-04-18 22:57:05 PDT
bmalloc: Merge the large and xlarge allocators
Attachments
Patch (121.28 KB, patch)
2016-04-18 23:04 PDT, Geoffrey Garen 		no flags
DetailsFormatted DiffDiff
Patch (121.32 KB, patch)
2016-04-19 00:16 PDT, Geoffrey Garen 		no flags
DetailsFormatted DiffDiff
Patch (121.36 KB, patch)
2016-04-19 00:33 PDT, Geoffrey Garen 		no flags
DetailsFormatted DiffDiff
Patch (121.88 KB, patch)
2016-04-19 00:38 PDT, Geoffrey Garen 		no flags
DetailsFormatted DiffDiff
Patch (121.89 KB, patch)
2016-04-19 00:42 PDT, Geoffrey Garen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Geoffrey Garen
Comment 1 2016-04-18 23:04:51 PDT
Created attachment 276697 [details] Patch
WebKit Commit Bot
Comment 2 2016-04-18 23:07:12 PDT
Attachment 276697 [details] did not pass style-queue: ERROR: Source/bmalloc/bmalloc/Map.h:113: Use 'WTFMove()' instead of 'std::move()'. [runtime/wtf_move] [4] Total errors found: 1 in 19 files If any of these errors are false positives, please file a bug against check-webkit-style.
Geoffrey Garen
Comment 3 2016-04-19 00:16:38 PDT
Created attachment 276699 [details] Patch
WebKit Commit Bot
Comment 4 2016-04-19 00:19:08 PDT
Attachment 276699 [details] did not pass style-queue: ERROR: Source/bmalloc/bmalloc/Map.h:113: Use 'WTFMove()' instead of 'std::move()'. [runtime/wtf_move] [4] Total errors found: 1 in 19 files If any of these errors are false positives, please file a bug against check-webkit-style.
Geoffrey Garen
Comment 5 2016-04-19 00:33:23 PDT
Created attachment 276701 [details] Patch
WebKit Commit Bot
Comment 6 2016-04-19 00:36:11 PDT
Attachment 276701 [details] did not pass style-queue: ERROR: Source/bmalloc/bmalloc/Map.h:113: Use 'WTFMove()' instead of 'std::move()'. [runtime/wtf_move] [4] Total errors found: 1 in 19 files If any of these errors are false positives, please file a bug against check-webkit-style.
Geoffrey Garen
Comment 7 2016-04-19 00:38:57 PDT
Created attachment 276702 [details] Patch
WebKit Commit Bot
Comment 8 2016-04-19 00:41:04 PDT
Attachment 276702 [details] did not pass style-queue: ERROR: Source/bmalloc/bmalloc/Map.h:113: Use 'WTFMove()' instead of 'std::move()'. [runtime/wtf_move] [4] Total errors found: 1 in 19 files If any of these errors are false positives, please file a bug against check-webkit-style.
Geoffrey Garen
Comment 9 2016-04-19 00:42:25 PDT
Created attachment 276703 [details] Patch
WebKit Commit Bot
Comment 10 2016-04-19 00:43:45 PDT
Attachment 276703 [details] did not pass style-queue: ERROR: Source/bmalloc/bmalloc/Map.h:113: Use 'WTFMove()' instead of 'std::move()'. [runtime/wtf_move] [4] Total errors found: 1 in 19 files If any of these errors are false positives, please file a bug against check-webkit-style.
Andreas Kling
Comment 11 2016-04-19 13:23:52 PDT
Comment on attachment 276703 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=276703&action=review r=me > Source/bmalloc/ChangeLog:81 > + (bmalloc::ChunkHash::hash): Added a hash function. The best hash function > + is a unique and monotonically increasing integer, and that's exactly what > + we typically get from the high bits of a Chunk, since the OS allocates > + Chunks at unique and increasing addresses. I learned something from this comment.
Geoffrey Garen
Comment 12 2016-04-19 15:48:33 PDT
Comment on attachment 276703 [details] Patch cq+ 🍀
WebKit Commit Bot
Comment 13 2016-04-19 16:36:04 PDT
Comment on attachment 276703 [details] Patch Clearing flags on attachment: 276703 Committed r199746: <http://trac.webkit.org/changeset/199746>
WebKit Commit Bot
Comment 14 2016-04-19 16:36:10 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.