Bug 156723

Summary: Context menu items related to fullscreen should be specific to standard fullscreen
Product: WebKit Reporter: Ada Chan <adachan>
Component: MediaAssignee: Ada Chan <adachan>
Status: RESOLVED FIXED    
Severity: Normal Keywords: InRadar
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch darin: review+

Ada Chan
Reported 2016-04-18 17:13:42 PDT
Context menu items related to fullscreen should be specific to standard fullscreen. Right now the code uses HTMLMediaElement::isFullscreen() to check whether it should display "Enter Full Screen" or "Exit Full Screen", which could return true for other fullscreen modes. We should use a more specific check since the action of "Enter Full Screen" is going to standard full screen. <rdar://problem/25452632>
Attachments
Patch (4.46 KB, patch)
2016-04-18 17:23 PDT, Ada Chan 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ada Chan
Comment 1 2016-04-18 17:23:11 PDT
Created attachment 276682 [details] Patch
Ada Chan
Comment 2 2016-04-19 10:59:06 PDT
Committed: http://trac.webkit.org/changeset/199733
Note You need to log in before you can comment on or make changes to this bug.