Bug 156719

Summary: Web Inspector: Debugger sidebar should include a warning message breakpoints are disabled
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web InspectorAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Proposed Fix
none
[IMAGE] Breakpoints Disabled Warning none

Joseph Pecoraro
Reported 2016-04-18 14:56:32 PDT
* SUMMARY Debugger sidebar should include a warning message breakpoints are disabled. * NOTES It should be easier to notice when breakpoints are disabled, and understand the consequences (breakpoints and debugger statements are disabled).
Attachments
[PATCH] Proposed Fix (7.50 KB, patch)
2016-09-08 00:33 PDT, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
[IMAGE] Breakpoints Disabled Warning (343.12 KB, image/png)
2016-09-08 00:33 PDT, Joseph Pecoraro 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2016-04-18 14:57:26 PDT
<rdar://problem/25787932>
Joseph Pecoraro
Comment 2 2016-09-08 00:33:30 PDT
Created attachment 288253 [details] [PATCH] Proposed Fix
Joseph Pecoraro
Comment 3 2016-09-08 00:33:55 PDT
Created attachment 288254 [details] [IMAGE] Breakpoints Disabled Warning
Blaze Burg
Comment 4 2016-09-08 10:18:29 PDT
Comment on attachment 288253 [details] [PATCH] Proposed Fix r=me It might be cleaner to use a View class eventually but this is fine for now.
WebKit Commit Bot
Comment 5 2016-09-08 10:39:54 PDT
Comment on attachment 288253 [details] [PATCH] Proposed Fix Clearing flags on attachment: 288253 Committed r205651: <http://trac.webkit.org/changeset/205651>
WebKit Commit Bot
Comment 6 2016-09-08 10:39:58 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.