Bug 156714

Summary: Swipe view gesture should be reversed in right-to-left contexts
Product: WebKit Reporter: Tim Horton <thorton>
Component: New BugsAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, berto, cgarcia, commit-queue, gustavo, mcatanzaro, mmaxfield, mrobinson, sam, simon.fraser, zalan
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Tim Horton
Reported 2016-04-18 13:34:35 PDT
Swipe view gesture should be reversed in right-to-left contexts
Attachments
Patch (15.70 KB, patch)
2016-04-18 13:34 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Patch (18.13 KB, patch)
2016-04-18 14:35 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Patch (18.70 KB, patch)
2016-04-18 14:58 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2016-04-18 13:34:55 PDT
Created attachment 276662 [details] Patch
WebKit Commit Bot
Comment 2 2016-04-18 13:36:32 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
WebKit Commit Bot
Comment 3 2016-04-18 13:36:43 PDT
Attachment 276662 [details] did not pass style-queue: ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:1107: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] Total errors found: 1 in 11 files If any of these errors are false positives, please file a bug against check-webkit-style.
Tim Horton
Comment 4 2016-04-18 14:35:36 PDT
Created attachment 276672 [details] Patch
WebKit Commit Bot
Comment 5 2016-04-18 14:38:25 PDT
Attachment 276672 [details] did not pass style-queue: ERROR: Source/WebKit2/UIProcess/UserInterfaceLayoutDirection.h:31: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] Total errors found: 1 in 12 files If any of these errors are false positives, please file a bug against check-webkit-style.
Tim Horton
Comment 6 2016-04-18 14:58:20 PDT
Created attachment 276673 [details] Patch
Tim Horton
Comment 7 2016-04-18 15:03:26 PDT
<rdar://problem/24249978>
WebKit Commit Bot
Comment 8 2016-04-18 16:00:14 PDT
Comment on attachment 276673 [details] Patch Clearing flags on attachment: 276673 Committed r199695: <http://trac.webkit.org/changeset/199695>
WebKit Commit Bot
Comment 9 2016-04-18 16:00:19 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.