| Summary: | Swipe view gesture should be reversed in right-to-left contexts | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Tim Horton <thorton> | ||||||||
| Component: | New Bugs | Assignee: | Tim Horton <thorton> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | andersca, berto, cgarcia, commit-queue, gustavo, mcatanzaro, mmaxfield, mrobinson, sam, simon.fraser, zalan | ||||||||
| Priority: | P2 | ||||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Tim Horton
2016-04-18 13:34:35 PDT
Created attachment 276662 [details]
Patch
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API Attachment 276662 [details] did not pass style-queue:
ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:1107: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
Total errors found: 1 in 11 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 276672 [details]
Patch
Attachment 276672 [details] did not pass style-queue:
ERROR: Source/WebKit2/UIProcess/UserInterfaceLayoutDirection.h:31: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
Total errors found: 1 in 12 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 276673 [details]
Patch
Comment on attachment 276673 [details] Patch Clearing flags on attachment: 276673 Committed r199695: <http://trac.webkit.org/changeset/199695> All reviewed patches have been landed. Closing bug. |