| Summary: | Web Inspector: Creating the CSSStyleDetailsSidebarPanel takes about 50ms (20%) of main load | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Timothy Hatcher <timothy> | ||||||||||||||
| Component: | Web Inspector | Assignee: | Matt Baker <mattbaker> | ||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||
| Severity: | Normal | CC: | bburg, commit-queue, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer | ||||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||||
| Hardware: | All | ||||||||||||||||
| OS: | All | ||||||||||||||||
| Attachments: |
|
||||||||||||||||
Created attachment 277171 [details]
[Profile] First optimization pass
Lazily creating the VisualStylesSidebar UI when the panel is shown reduces CSSStyleDetailsSidebarPanel load time from 50ms to ~14ms.
Will try lazy loading other panels next.
Created attachment 277180 [details]
[Profile] 2nd optimization pass
Although load times necessarily vary, lazy loading all sidebars sped up the loading of the frontend by over 40%!
CSSStyleDetailsSidebarPanel now takes > 2ms at startup if hidden by default.
(In reply to comment #3) > Created attachment 277180 [details] > [Profile] 2nd optimization pass > > CSSStyleDetailsSidebarPanel now takes > 2ms at startup if hidden by default. < 2ms Created attachment 279508 [details]
[Patch] Proposed Fix
Created attachment 279518 [details]
[Patch] Proposed Fix
Comment on attachment 279518 [details]
[Patch] Proposed Fix
Looks like this breaks DataGrid column layout
Created attachment 279527 [details]
[Patch] Proposed Fix
Comment on attachment 279527 [details] [Patch] Proposed Fix Clearing flags on attachment: 279527 Committed r201245: <http://trac.webkit.org/changeset/201245> All reviewed patches have been landed. Closing bug. |
Created attachment 276644 [details] Screenshot of a profile We should be able to lazy land most of CSSStyleDetailsSidebarPanel and the sub-panels to speed this up.