Bug 156706

Summary: Remove all use of Deprecated::ScriptValue in generated bindings
Product: WebKit Reporter: Darin Adler <darin>
Component: BindingsAssignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Normal CC: alecflett, beidson, cdumez, cgarcia, commit-queue, esprehn+autocc, ggaren, jsbell, kondapallykalyan, sam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch beidson: review+

Darin Adler
Reported 2016-04-18 09:30:45 PDT
Remove all use of Deprecated::ScriptValue in generated bindings
Attachments
Patch (21.04 KB, patch)
2016-04-18 09:38 PDT, Darin Adler 		beidson: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Darin Adler
Comment 1 2016-04-18 09:38:11 PDT
Created attachment 276643 [details] Patch
Darin Adler
Comment 2 2016-04-18 09:39:49 PDT
Brady, I think you’ll like this patch even more than the last one. This removes Deprecated::ScriptValue use entirely from the JavaScript bindings generator. And it gets us really close to removing the need for ImplementationReturnType entirely.
Brady Eidson
Comment 3 2016-04-18 10:05:09 PDT
I have not opened the patch yet, but can't believe it's as small as it is.
Brady Eidson
Comment 4 2016-04-18 10:12:59 PDT
Comment on attachment 276643 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=276643&action=review > Source/WebCore/Modules/indexeddb/IDBKeyRange.h:70 > + // FIXME: Eventually shoudl probably change all callers to call the ExecState version. shoudl
Brady Eidson
Comment 5 2016-04-18 10:13:45 PDT
mac-wk2 ews - while not done yet - suggests at least 1 test failure.
Darin Adler
Comment 6 2016-04-18 19:58:28 PDT
Committed r199704: <http://trac.webkit.org/changeset/199704>
Darin Adler
Comment 8 2016-04-18 22:05:38 PDT
Fixed that. Committed r199706: <http://trac.webkit.org/changeset/199706>
Note You need to log in before you can comment on or make changes to this bug.