| Summary: | Remove all use of Deprecated::ScriptValue in generated bindings | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Darin Adler <darin> | ||||
| Component: | Bindings | Assignee: | Darin Adler <darin> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | alecflett, beidson, cdumez, cgarcia, commit-queue, esprehn+autocc, ggaren, jsbell, kondapallykalyan, sam | ||||
| Priority: | P2 | ||||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Darin Adler
2016-04-18 09:30:45 PDT
Created attachment 276643 [details]
Patch
Brady, I think you’ll like this patch even more than the last one. This removes Deprecated::ScriptValue use entirely from the JavaScript bindings generator. And it gets us really close to removing the need for ImplementationReturnType entirely. I have not opened the patch yet, but can't believe it's as small as it is. Comment on attachment 276643 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=276643&action=review > Source/WebCore/Modules/indexeddb/IDBKeyRange.h:70 > + // FIXME: Eventually shoudl probably change all callers to call the ExecState version. shoudl mac-wk2 ews - while not done yet - suggests at least 1 test failure. Committed r199704: <http://trac.webkit.org/changeset/199704> This broke bindings tests: https://build.webkit.org/builders/Apple%20El%20Capitan%20Release%20WK2%20%28Tests%29/builds/5240/steps/bindings-generation-tests/logs/stdio Fixed that. Committed r199706: <http://trac.webkit.org/changeset/199706> |