Bug 156661

Summary: [GTK] Possible off-by-one in hyphenation code
Product: WebKit Reporter: Michael Catanzaro <mcatanzaro>
Component: WebKitGTKAssignee: Martin Robinson <mrobinson>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, commit-queue, mcatanzaro, mrobinson
Priority: P2    
Version: Other   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Patch none

Michael Catanzaro
Reported 2016-04-16 08:50:37 PDT
I've noticed an interesting difference in how we hyphenate words compared to Firefox. E.g. some examples from https://blogs.gnome.org/mclasen/2016/04/15/my-first-xdg-app/ Firefox: environ-ment WebKit: enviro-nment Firefox: hav-ing WebKit: ha-ving Firefox: run-time WebKit: ru-ntime Firefox: com-mand WebKit: co-mmand Firefox's hyphenations are clearly superior. This looks pretty suspicious; could we have an off-by-one in our code?
Attachments
Patch (427.33 KB, patch)
2016-04-18 14:13 PDT, Martin Robinson 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Martin Robinson
Comment 1 2016-04-18 10:46:20 PDT
Michael, I think you are correct. I'm working on a fix for this now.
Martin Robinson
Comment 2 2016-04-18 11:01:49 PDT
*** Bug 143924 has been marked as a duplicate of this bug. ***
Martin Robinson
Comment 3 2016-04-18 14:13:30 PDT
Created attachment 276666 [details] Patch
WebKit Commit Bot
Comment 4 2016-04-18 19:33:10 PDT
Comment on attachment 276666 [details] Patch Clearing flags on attachment: 276666 Committed r199703: <http://trac.webkit.org/changeset/199703>
WebKit Commit Bot
Comment 5 2016-04-18 19:33:15 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.