Bug 156658

Summary: Add support for NSSharingService to MiniBrowser, for no great reasons
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal CC: darin
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch darin: review+

Sam Weinig
Reported 2016-04-15 22:35:32 PDT
Add support for NSSharingService to MiniBrowser, for no great reasons
Attachments
Patch (18.40 KB, patch)
2016-04-15 22:38 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (18.17 KB, patch)
2016-04-15 22:39 PDT, Sam Weinig 		darin: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2016-04-15 22:38:57 PDT
Created attachment 276546 [details] Patch
Sam Weinig
Comment 2 2016-04-15 22:39:27 PDT
Created attachment 276547 [details] Patch
Darin Adler
Comment 3 2016-04-15 22:43:33 PDT
Comment on attachment 276547 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=276547&action=review > Tools/MiniBrowser/mac/BrowserWindowController.m:212 > + NSRect rect = [self.window convertRectToScreen:self.mainContentView.bounds]; > + > + return rect; Why the local variable?
Darin Adler
Comment 4 2016-04-15 22:43:52 PDT
Should we port MiniBrowser to Swift at some point?
Sam Weinig
Comment 5 2016-04-16 00:21:43 PDT
(In reply to comment #3) > Comment on attachment 276547 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=276547&action=review > > > Tools/MiniBrowser/mac/BrowserWindowController.m:212 > > + NSRect rect = [self.window convertRectToScreen:self.mainContentView.bounds]; > > + > > + return rect; > > Why the local variable? I was playing with rect earlier and forgot to fix it. Will fix before landing.
Sam Weinig
Comment 6 2016-04-16 00:22:30 PDT
(In reply to comment #5) > (In reply to comment #3) > > Comment on attachment 276547 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=276547&action=review > > > > > Tools/MiniBrowser/mac/BrowserWindowController.m:212 > > > + NSRect rect = [self.window convertRectToScreen:self.mainContentView.bounds]; > > > + > > > + return rect; > > > > Why the local variable? > > I was playing with rect earlier and forgot to fix it. Will fix before > landing. Probably. Need to figure out what OSes people are using this on before doing it to make sure it's kosher.
Sam Weinig
Comment 7 2016-04-16 17:10:30 PDT
Committed r199630: <http://trac.webkit.org/changeset/199630>
Note You need to log in before you can comment on or make changes to this bug.