Bug 15658

Summary: Speed up SunSpider by 2.4% by removing checks for isOutOfMemory()
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: JavaScriptCoreAssignee: Eric Seidel (no email) <eric>
Status: RESOLVED FIXED    
Severity: Enhancement CC: ggaren, mjs, oliver
Priority: P2    
Version: 523.x (Safari 3)   
Hardware: Mac   
OS: OS X 10.4   
Attachments:
Description Flags
fix
darin: review-
better fix (should fix both issues raised by darin) mjs: review+

Eric Seidel (no email)
Reported 2007-10-24 03:33:34 PDT
Speed up SunSpider by 2.2% by checks for isOutOfMemory() See attached patch.
Attachments
fix (5.67 KB, patch)
2007-10-24 03:36 PDT, Eric Seidel (no email) 		darin: review-
DetailsFormatted DiffDiff
better fix (should fix both issues raised by darin) (5.68 KB, patch)
2007-10-24 12:05 PDT, Eric Seidel (no email) 		mjs: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2007-10-24 03:36:21 PDT
Created attachment 16831 [details] fix
Eric Seidel (no email)
Comment 2 2007-10-24 03:49:12 PDT
Actually now SunSpider is telling me it's 2.4% faster. :)
Darin Adler
Comment 3 2007-10-24 07:47:12 PDT
Comment on attachment 16831 [details] fix r=me
Darin Adler
Comment 4 2007-10-24 09:35:31 PDT
Comment on attachment 16831 [details] fix This version of the patch isn't quite right. For one thing, once memoryFull is set true, this patch will *never* set it back to false. That was not the old behavior. For another, we hit an assertion immediately in the debug build because operationInProgress is still true.
Darin Adler
Comment 5 2007-10-24 10:17:05 PDT
We *really* want this fix, but I ran out of time this morning trying to fix the two tiny problems with it and land it.
Eric Seidel (no email)
Comment 6 2007-10-24 12:05:37 PDT
Created attachment 16841 [details] better fix (should fix both issues raised by darin)
Maciej Stachowiak
Comment 7 2007-10-24 14:36:14 PDT
Comment on attachment 16841 [details] better fix (should fix both issues raised by darin) r=me
Eric Seidel (no email)
Comment 8 2007-10-24 14:53:46 PDT
r27001
Note You need to log in before you can comment on or make changes to this bug.