Bug 156578

Summary: [css-grid] Implement CSSGridTemplateAreasValue::equals
Product: WebKit Reporter: Manuel Rego Casasnovas <rego>
Component: Layout and RenderingAssignee: Manuel Rego Casasnovas <rego>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, jfernandez, rego, simon.fraser, svillar
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 60731    
Attachments:
Description Flags
Patch none

Description Manuel Rego Casasnovas 2016-04-14 06:16:00 PDT
[css-grid] Implement CSSGridTemplateAreasValue::equals
Comment 1 Manuel Rego Casasnovas 2016-04-14 06:16:57 PDT
Created attachment 276394 [details]
Patch
Comment 2 Manuel Rego Casasnovas 2016-04-14 06:18:32 PDT
There's a crash (infinite loop) if you just do something like this in a grid:
  grid.style.webkitGridTemplateAreas = '"a"';
  grid.style.webkitGridTemplateAreas = '"b"';

This was already fixed in Blink a long time ago:
https://codereview.chromium.org/1124063004
Comment 3 Manuel Rego Casasnovas 2016-04-14 06:18:52 PDT
There's a crash (infinite loop) if you just do something like this in a grid:
  grid.style.webkitGridTemplateAreas = '"a"';
  grid.style.webkitGridTemplateAreas = '"b"';

This was already fixed in Blink a long time ago:
https://codereview.chromium.org/1124063004
Comment 4 WebKit Commit Bot 2016-04-14 13:49:03 PDT
Comment on attachment 276394 [details]
Patch

Clearing flags on attachment: 276394

Committed r199551: <http://trac.webkit.org/changeset/199551>
Comment 5 WebKit Commit Bot 2016-04-14 13:49:06 PDT
All reviewed patches have been landed.  Closing bug.