Summary: | [css-grid] Implement CSSGridTemplateAreasValue::equals | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Manuel Rego Casasnovas <rego> | ||||
Component: | Layout and Rendering | Assignee: | Manuel Rego Casasnovas <rego> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, jfernandez, rego, simon.fraser, svillar | ||||
Priority: | P2 | ||||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 60731 | ||||||
Attachments: |
|
Description
Manuel Rego Casasnovas
2016-04-14 06:16:00 PDT
Created attachment 276394 [details]
Patch
There's a crash (infinite loop) if you just do something like this in a grid: grid.style.webkitGridTemplateAreas = '"a"'; grid.style.webkitGridTemplateAreas = '"b"'; This was already fixed in Blink a long time ago: https://codereview.chromium.org/1124063004 There's a crash (infinite loop) if you just do something like this in a grid: grid.style.webkitGridTemplateAreas = '"a"'; grid.style.webkitGridTemplateAreas = '"b"'; This was already fixed in Blink a long time ago: https://codereview.chromium.org/1124063004 Comment on attachment 276394 [details] Patch Clearing flags on attachment: 276394 Committed r199551: <http://trac.webkit.org/changeset/199551> All reviewed patches have been landed. Closing bug. |