Bug 156578 - [css-grid] Implement CSSGridTemplateAreasValue::equals
Summary: [css-grid] Implement CSSGridTemplateAreasValue::equals
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Manuel Rego Casasnovas
URL:
Keywords:
Depends on:
Blocks: 60731
  Show dependency tree / graph
 
Reported: 2016-04-14 06:16 PDT by Manuel Rego Casasnovas
Modified: 2016-04-14 13:49 PDT (History)
5 users (show)

See Also:

Attachments
Patch (4.39 KB, patch)
2016-04-14 06:16 PDT, Manuel Rego Casasnovas 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Manuel Rego Casasnovas 2016-04-14 06:16:00 PDT 
[css-grid] Implement CSSGridTemplateAreasValue::equals
Comment 1 Manuel Rego Casasnovas 2016-04-14 06:16:57 PDT 
Created attachment 276394 [details]
Patch
Comment 2 Manuel Rego Casasnovas 2016-04-14 06:18:32 PDT 
There's a crash (infinite loop) if you just do something like this in a grid:
  grid.style.webkitGridTemplateAreas = '"a"';
  grid.style.webkitGridTemplateAreas = '"b"';

This was already fixed in Blink a long time ago:
https://codereview.chromium.org/1124063004
Comment 3 Manuel Rego Casasnovas 2016-04-14 06:18:52 PDT 
There's a crash (infinite loop) if you just do something like this in a grid:
  grid.style.webkitGridTemplateAreas = '"a"';
  grid.style.webkitGridTemplateAreas = '"b"';

This was already fixed in Blink a long time ago:
https://codereview.chromium.org/1124063004
Comment 4 WebKit Commit Bot 2016-04-14 13:49:03 PDT 
Comment on attachment 276394 [details]
Patch

Clearing flags on attachment: 276394

Committed r199551: <http://trac.webkit.org/changeset/199551>
Comment 5 WebKit Commit Bot 2016-04-14 13:49:06 PDT 
All reviewed patches have been landed.  Closing bug.