RESOLVED FIXED 156578
[css-grid] Implement CSSGridTemplateAreasValue::equals 
https://bugs.webkit.org/show_bug.cgi?id=156578
Summary [css-grid] Implement CSSGridTemplateAreasValue::equals
Manuel Rego Casasnovas
Reported 2016-04-14 06:16:00 PDT
[css-grid] Implement CSSGridTemplateAreasValue::equals
Attachments
Patch (4.39 KB, patch)
2016-04-14 06:16 PDT, Manuel Rego Casasnovas 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Manuel Rego Casasnovas
Comment 1 2016-04-14 06:16:57 PDT
Created attachment 276394 [details] Patch
Manuel Rego Casasnovas
Comment 2 2016-04-14 06:18:32 PDT
There's a crash (infinite loop) if you just do something like this in a grid: grid.style.webkitGridTemplateAreas = '"a"'; grid.style.webkitGridTemplateAreas = '"b"'; This was already fixed in Blink a long time ago: https://codereview.chromium.org/1124063004
Manuel Rego Casasnovas
Comment 3 2016-04-14 06:18:52 PDT
There's a crash (infinite loop) if you just do something like this in a grid: grid.style.webkitGridTemplateAreas = '"a"'; grid.style.webkitGridTemplateAreas = '"b"'; This was already fixed in Blink a long time ago: https://codereview.chromium.org/1124063004
WebKit Commit Bot
Comment 4 2016-04-14 13:49:03 PDT
Comment on attachment 276394 [details] Patch Clearing flags on attachment: 276394 Committed r199551: <http://trac.webkit.org/changeset/199551>
WebKit Commit Bot
Comment 5 2016-04-14 13:49:06 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.