Bug 15656

Summary: [GTK] Implement WebCore::Widget::isEnabled/setEnabled
Product: WebKit Reporter: Jan Alonzo <jmalonzo>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Enhancement Keywords: Gtk
Priority: P3    
Version: 523.x (Safari 3)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
implement isEnabled and setEnabled alp: review+

Jan Alonzo
Reported 2007-10-23 21:41:09 PDT
Attached is a patch implementing Widget::isEnabled and Widget::setEnabled.
Attachments
implement isEnabled and setEnabled (1.10 KB, patch)
2007-10-23 21:41 PDT, Jan Alonzo 		alp: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jan Alonzo
Comment 1 2007-10-23 21:41:56 PDT
Created attachment 16828 [details] implement isEnabled and setEnabled
Alp Toker
Comment 2 2007-10-23 22:37:32 PDT
I'm curious, does this patch make WidgetGtk work any better? The rest of the file looks a bit confused right now, like it needs a cleanup. Most other places where the GTK+ widget is used null-check it first.
Jan Alonzo
Comment 3 2007-10-23 23:18:18 PDT
Hi Alp. Are you suggesting that WidgetGtk needs cleanup as well? If that's the case I can refactor it and submit a refactored patch.
Alp Toker
Comment 4 2007-10-25 15:07:32 PDT
Fixed in r27069 (with a check added).
Note You need to log in before you can comment on or make changes to this bug.