Bug 15656 - [GTK] Implement WebCore::Widget::isEnabled/setEnabled
Summary: [GTK] Implement WebCore::Widget::isEnabled/setEnabled
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 523.x (Safari 3)
Hardware: PC Linux
: P3 Enhancement
Assignee: Nobody
Keywords: Gtk
Depends on:
Reported: 2007-10-23 21:41 PDT by Jan Alonzo
Modified: 2007-10-25 15:08 PDT (History)
0 users

See Also:

implement isEnabled and setEnabled (1.10 KB, patch)
2007-10-23 21:41 PDT, Jan Alonzo
alp: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Alonzo 2007-10-23 21:41:09 PDT
Attached is a patch implementing Widget::isEnabled and Widget::setEnabled.
Comment 1 Jan Alonzo 2007-10-23 21:41:56 PDT
Created attachment 16828 [details]
implement isEnabled and setEnabled
Comment 2 Alp Toker 2007-10-23 22:37:32 PDT
I'm curious, does this patch make WidgetGtk work any better? The rest of the file looks a bit confused right now, like it needs a cleanup.

Most other places where the GTK+ widget is used null-check it first.
Comment 3 Jan Alonzo 2007-10-23 23:18:18 PDT
Hi Alp. Are you suggesting that WidgetGtk needs cleanup as well? If that's the case I can refactor it and submit a refactored patch.
Comment 4 Alp Toker 2007-10-25 15:07:32 PDT
Fixed in r27069 (with a check added).