WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
15656
[GTK] Implement WebCore::Widget::isEnabled/setEnabled
https://bugs.webkit.org/show_bug.cgi?id=15656
Summary
[GTK] Implement WebCore::Widget::isEnabled/setEnabled
Jan Alonzo
Reported
2007-10-23 21:41:09 PDT
Attached is a patch implementing Widget::isEnabled and Widget::setEnabled.
Attachments
implement isEnabled and setEnabled
(1.10 KB, patch)
2007-10-23 21:41 PDT
,
Jan Alonzo
alp
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Jan Alonzo
Comment 1
2007-10-23 21:41:56 PDT
Created
attachment 16828
[details]
implement isEnabled and setEnabled
Alp Toker
Comment 2
2007-10-23 22:37:32 PDT
I'm curious, does this patch make WidgetGtk work any better? The rest of the file looks a bit confused right now, like it needs a cleanup. Most other places where the GTK+ widget is used null-check it first.
Jan Alonzo
Comment 3
2007-10-23 23:18:18 PDT
Hi Alp. Are you suggesting that WidgetGtk needs cleanup as well? If that's the case I can refactor it and submit a refactored patch.
Alp Toker
Comment 4
2007-10-25 15:07:32 PDT
Fixed in
r27069
(with a check added).
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug