Bug 156555

Summary: PolymorphicAccess should try to generate a stub only once
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, keith_miller, mark.lam, msaboff, saam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
the patch ggaren: review+

Filip Pizlo
Reported 2016-04-13 14:01:36 PDT
Currently, we don't do any buffering of access cases prior to the first stub generation. We only enable it after a stub has been generated. I implemented buffering that way to be conservative. Now we should push it further and always buffer. The outcome ought to be that most ICs only generate a stub once.
Attachments
the patch (7.00 KB, patch)
2016-04-14 15:14 PDT, Filip Pizlo 		ggaren: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2016-04-14 15:14:01 PDT
Created attachment 276437 [details] the patch
Geoffrey Garen
Comment 2 2016-04-14 15:22:04 PDT
Comment on attachment 276437 [details] the patch r=me
Filip Pizlo
Comment 3 2016-04-14 16:08:24 PDT
Landed in http://trac.webkit.org/changeset/199566
Note You need to log in before you can comment on or make changes to this bug.