Summary: | REGRESSION (r199401): Internal builds of Safari hang on launch | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Daniel Bates <dbates> | ||||
Component: | WebKit2 | Assignee: | Daniel Bates <dbates> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | aestes, andersca, bfulgham, jberlin, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar, Regression | ||||
Version: | WebKit Local Build | ||||||
Hardware: | Mac | ||||||
OS: | OS X 10.11 | ||||||
Attachments: |
|
Description
Daniel Bates
2016-04-13 10:23:54 PDT
Created attachment 276332 [details]
Patch
Comment on attachment 276332 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=276332&action=review > Source/WebKit2/Shared/mac/CodeSigning.mm:101 > + RetainPtr<SecCodeRef> code = secCodeForProcess(pid); Can use auto here. Committed r199504: <http://trac.webkit.org/changeset/199504> Comment on attachment 276332 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=276332&action=review > Source/WebKit2/Shared/mac/CodeSigning.mm:58 > + OSStatus errorCode = noErr; > + // FIXME: We should RELEASE_ASSERT() that SecCodeCopyGuestWithAttributes() returns without error. > + if ((errorCode = SecCodeCopyGuestWithAttributes(nullptr, attributes.get(), kSecCSDefaultFlags, &code))) { > + WTFLogAlways("SecCodeCopyGuestWithAttributes() failed with error: %ld\n", static_cast<long>(errorCode)); > + return nullptr; > + } > RELEASE_ASSERT(!SecCodeCopyGuestWithAttributes(nullptr, attributes.get(), kSecCSDefaultFlags, &code)); I don’t think you wanted to call this twice. (In reply to comment #5) > > Source/WebKit2/Shared/mac/CodeSigning.mm:58 > > [...] > > RELEASE_ASSERT(!SecCodeCopyGuestWithAttributes(nullptr, attributes.get(), kSecCSDefaultFlags, &code)); > > I don’t think you wanted to call this twice. Fixed in <http://trac.webkit.org/changeset/199528>. |