Bug 156544

Summary: FindWebP should not be misguided by pkg-config when cross-compiling.
Product: WebKit Reporter: Konstantin Tokarev <annulen>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: cgarcia, clopez, commit-queue, gyuyoung.kim, lforschler, mario, mcatanzaro, mrobinson, ossy, tpopela
Priority: P2    
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Konstantin Tokarev
Reported 2016-04-13 09:58:11 PDT
We should use pkg-config output only as a hint, like other modules do.
Attachments
Patch (2.05 KB, patch)
2016-04-13 10:00 PDT, Konstantin Tokarev 		no flags
DetailsFormatted DiffDiff
Patch (2.05 KB, patch)
2016-04-13 10:31 PDT, Konstantin Tokarev 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Konstantin Tokarev
Comment 1 2016-04-13 10:00:42 PDT
Created attachment 276330 [details] Patch
Konstantin Tokarev
Comment 2 2016-04-13 10:31:41 PDT
Created attachment 276331 [details] Patch
Michael Catanzaro
Comment 3 2016-04-13 10:49:22 PDT
Comment on attachment 276331 [details] Patch By the way, do you have committer access yet? You can stop setting cq? and move it straight to cq+ once you do.
Konstantin Tokarev
Comment 4 2016-04-13 10:57:22 PDT
Not yet.
WebKit Commit Bot
Comment 5 2016-04-13 15:58:22 PDT
Comment on attachment 276331 [details] Patch Clearing flags on attachment: 276331 Committed r199518: <http://trac.webkit.org/changeset/199518>
WebKit Commit Bot
Comment 6 2016-04-13 15:58:28 PDT
All reviewed patches have been landed. Closing bug.
Carlos Alberto Lopez Perez
Comment 7 2016-04-13 18:06:41 PDT
Continuous build broke with this. I have triggered clean builds on all the GTK+ bots.
Konstantin Tokarev
Comment 8 2016-04-14 02:47:10 PDT
(In reply to comment #7) > Continuous build broke with this. > > I have triggered clean builds on all the GTK+ bots. This patch requires one clean build after landing, after that continuous builds should work fine (at least it works in my local tests).
Carlos Alberto Lopez Perez
Comment 9 2016-04-14 03:26:05 PDT
(In reply to comment #8) > (In reply to comment #7) > > Continuous build broke with this. > > > > I have triggered clean builds on all the GTK+ bots. > > This patch requires one clean build after landing, after that continuous > builds should work fine (at least it works in my local tests). Yes. that is what I wanted to say :)
Note You need to log in before you can comment on or make changes to this bug.