Bug 156495

Summary: Remove UsePointersEvenForNonNullableObjectArguments from DataTransfer
Product: WebKit Reporter: Darin Adler <darin>
Component: DOMAssignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, esprehn+autocc, kangil.han, kondapallykalyan, sam, youennf
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Darin Adler
Reported 2016-04-11 22:23:49 PDT
Remove UsePointersEvenForNonNullableObjectArguments from DataTransfer
Attachments
Patch (1.59 KB, patch)
2016-04-11 22:24 PDT, Darin Adler 		no flags
DetailsFormatted DiffDiff
Patch (1.56 KB, patch)
2016-04-13 09:12 PDT, Darin Adler 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Darin Adler
Comment 1 2016-04-11 22:24:25 PDT
Created attachment 276221 [details] Patch
Chris Dumez
Comment 2 2016-04-12 08:27:58 PDT
Comment on attachment 276221 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=276221&action=review > Source/WebCore/dom/DataTransfer.idl:41 > + void setDragImage(Element? image, long x, long y); Hmm, this does not match the spec: https://html.spec.whatwg.org/multipage/interaction.html#datatransfer
Darin Adler
Comment 3 2016-04-12 09:20:39 PDT
Comment on attachment 276221 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=276221&action=review >> Source/WebCore/dom/DataTransfer.idl:41 >> + void setDragImage(Element? image, long x, long y); > > Hmm, this does not match the spec: > https://html.spec.whatwg.org/multipage/interaction.html#datatransfer Our behavior of accepting null to mean we should remove/clear the drag image predates the spec by many years. It’s OK to change to match the specification, but we’d want to add regression tests and consider the backwards compatibility costs of making the change.
Darin Adler
Comment 4 2016-04-12 09:20:59 PDT
Maybe we should add a FIXME comment about matching the specification in the future?
Chris Dumez
Comment 5 2016-04-12 09:24:42 PDT
(In reply to comment #4) > Maybe we should add a FIXME comment about matching the specification in the > future? Sound good to me.
Darin Adler
Comment 6 2016-04-13 09:12:15 PDT
Created attachment 276326 [details] Patch
Chris Dumez
Comment 7 2016-04-13 09:21:24 PDT
Comment on attachment 276326 [details] Patch r=me
WebKit Commit Bot
Comment 8 2016-04-13 10:13:05 PDT
Comment on attachment 276326 [details] Patch Clearing flags on attachment: 276326 Committed r199500: <http://trac.webkit.org/changeset/199500>
WebKit Commit Bot
Comment 9 2016-04-13 10:13:09 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.