| Summary: | Remove UsePointersEvenForNonNullableObjectArguments from HTMLOptionsCollection | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Darin Adler <darin> | ||||
| Component: | DOM | Assignee: | Darin Adler <darin> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | cdumez, commit-queue, esprehn+autocc, gyuyoung.kim, kondapallykalyan, sam, youennf | ||||
| Priority: | P2 | ||||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Darin Adler
2016-04-11 21:20:32 PDT
Created attachment 276214 [details]
Patch
Comment on attachment 276214 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=276214&action=review r=me > Source/WebCore/html/HTMLOptionsCollection.h:42 > + HTMLOptionElement* item(unsigned offset) const final; is this the pattern now? final seems redundant since the class already is final. (In reply to comment #2) > > Source/WebCore/html/HTMLOptionsCollection.h:42 > > + HTMLOptionElement* item(unsigned offset) const final; > > is this the pattern now? > final seems redundant since the class already is final. This was discussed on webkit-dev: https://lists.webkit.org/pipermail/webkit-dev/2016-March/028018.html https://lists.webkit.org/pipermail/webkit-dev/2016-March/028019.html https://lists.webkit.org/pipermail/webkit-dev/2016-March/028021.html https://lists.webkit.org/pipermail/webkit-dev/2016-March/028020.html https://lists.webkit.org/pipermail/webkit-dev/2016-March/028022.html That lats message is where the discussion ended. If you like we can debate it again. (In reply to comment #3) > (In reply to comment #2) > > > Source/WebCore/html/HTMLOptionsCollection.h:42 > > > + HTMLOptionElement* item(unsigned offset) const final; > > > > is this the pattern now? > > final seems redundant since the class already is final. > > This was discussed on webkit-dev: > > https://lists.webkit.org/pipermail/webkit-dev/2016-March/028018.html > https://lists.webkit.org/pipermail/webkit-dev/2016-March/028019.html > https://lists.webkit.org/pipermail/webkit-dev/2016-March/028021.html > https://lists.webkit.org/pipermail/webkit-dev/2016-March/028020.html > https://lists.webkit.org/pipermail/webkit-dev/2016-March/028022.html > > That lats message is where the discussion ended. If you like we can debate > it again. I don't really mind it, I was merely curious. Comment on attachment 276214 [details] Patch Clearing flags on attachment: 276214 Committed r199335: <http://trac.webkit.org/changeset/199335> All reviewed patches have been landed. Closing bug. |