Bug 156475

Summary: Web Inspector: Unstyled nodes in ObjectTree previews look poor
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web InspectorAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Proposed Fix
none
[IMAGE] Before
none
[IMAGE] After none

Joseph Pecoraro
Reported 2016-04-11 15:24:49 PDT
* SUMMARY Unstyled nodes in ObjectTree previews look poor. Previously <div class="foo"> would have been "div.foo { ... }". For heap allocations I changed the description of nodes to just send <div class="foo"> and we would highlight it. Do the same for ObjectPreviews and avoid cluttering the UI with {...} properties.
Attachments
[PATCH] Proposed Fix (3.26 KB, patch)
2016-04-11 15:40 PDT, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
[IMAGE] Before (49.23 KB, image/png)
2016-04-11 15:41 PDT, Joseph Pecoraro 		no flags
Details
[IMAGE] After (46.24 KB, image/png)
2016-04-11 15:41 PDT, Joseph Pecoraro 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2016-04-11 15:25:21 PDT
<rdar://problem/25667351>
Joseph Pecoraro
Comment 2 2016-04-11 15:40:53 PDT
Created attachment 276176 [details] [PATCH] Proposed Fix
Joseph Pecoraro
Comment 3 2016-04-11 15:41:07 PDT
Created attachment 276177 [details] [IMAGE] Before
Joseph Pecoraro
Comment 4 2016-04-11 15:41:18 PDT
Created attachment 276178 [details] [IMAGE] After
WebKit Commit Bot
Comment 5 2016-04-11 16:47:08 PDT
Comment on attachment 276176 [details] [PATCH] Proposed Fix Clearing flags on attachment: 276176 Committed r199322: <http://trac.webkit.org/changeset/199322>
WebKit Commit Bot
Comment 6 2016-04-11 16:47:12 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.