| Summary: | Build MiniBrowser with CMake on Mac | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alex Christensen <achristensen> | ||||
| Component: | New Bugs | Assignee: | Alex Christensen <achristensen> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | bfulgham, cdumez, dbates | ||||
| Priority: | P2 | ||||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Alex Christensen
2016-04-11 11:49:09 PDT
Created attachment 276160 [details]
Patch
Comment on attachment 276160 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=276160&action=review > Tools/MiniBrowser/mac/CMakeLists.txt:3 > +add_definitions("-include MiniBrowser_Prefix.pch -DWEBCORE_EXPORT=") Can you elaborate on the purpose of defining WEBCORE_EXPORT to be the empty string? > Tools/MiniBrowser/mac/CMakeLists.txt:12 > + ${MINIBROWSER_DIR}/AppDelegate.m > + ${MINIBROWSER_DIR}/BrowserWindowController.m > + ${MINIBROWSER_DIR}/ExtensionManagerWindowController.m > + ${MINIBROWSER_DIR}/main.m > + ${MINIBROWSER_DIR}/SettingsController.m > + ${MINIBROWSER_DIR}/WK1BrowserWindowController.m > + ${MINIBROWSER_DIR}/WK2BrowserWindowController.m Please sort these entries according to the UNIX sort command. Committed with a FIXME for the WEBCORE_EXPORT to http://trac.webkit.org/changeset/199338 |