Bug 156471

Summary: Build MiniBrowser with CMake on Mac
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, cdumez, dbates
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch dbates: review+

Alex Christensen
Reported 2016-04-11 11:49:09 PDT
Build MiniBrowser with CMake on Mac
Attachments
Patch (4.55 KB, patch)
2016-04-11 11:50 PDT, Alex Christensen 		dbates: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2016-04-11 11:50:05 PDT
Created attachment 276160 [details] Patch
Daniel Bates
Comment 2 2016-04-11 16:01:18 PDT
Comment on attachment 276160 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=276160&action=review > Tools/MiniBrowser/mac/CMakeLists.txt:3 > +add_definitions("-include MiniBrowser_Prefix.pch -DWEBCORE_EXPORT=") Can you elaborate on the purpose of defining WEBCORE_EXPORT to be the empty string? > Tools/MiniBrowser/mac/CMakeLists.txt:12 > + ${MINIBROWSER_DIR}/AppDelegate.m > + ${MINIBROWSER_DIR}/BrowserWindowController.m > + ${MINIBROWSER_DIR}/ExtensionManagerWindowController.m > + ${MINIBROWSER_DIR}/main.m > + ${MINIBROWSER_DIR}/SettingsController.m > + ${MINIBROWSER_DIR}/WK1BrowserWindowController.m > + ${MINIBROWSER_DIR}/WK2BrowserWindowController.m Please sort these entries according to the UNIX sort command.
Alex Christensen
Comment 3 2016-04-12 00:19:37 PDT
Committed with a FIXME for the WEBCORE_EXPORT to http://trac.webkit.org/changeset/199338
Note You need to log in before you can comment on or make changes to this bug.