Bug 156471 - Build MiniBrowser with CMake on Mac
Summary: Build MiniBrowser with CMake on Mac
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-04-11 11:49 PDT by Alex Christensen
Modified: 2016-04-12 00:19 PDT (History)
3 users (show)

See Also:

Attachments
Patch (4.55 KB, patch)
2016-04-11 11:50 PDT, Alex Christensen 		dbates: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2016-04-11 11:49:09 PDT 
Build MiniBrowser with CMake on Mac
Comment 1 Alex Christensen 2016-04-11 11:50:05 PDT 
Created attachment 276160 [details]
Patch
Comment 2 Daniel Bates 2016-04-11 16:01:18 PDT 
Comment on attachment 276160 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=276160&action=review

> Tools/MiniBrowser/mac/CMakeLists.txt:3
> +add_definitions("-include MiniBrowser_Prefix.pch -DWEBCORE_EXPORT=")

Can you elaborate on the purpose of defining WEBCORE_EXPORT to be the empty string?

> Tools/MiniBrowser/mac/CMakeLists.txt:12
> +    ${MINIBROWSER_DIR}/AppDelegate.m
> +    ${MINIBROWSER_DIR}/BrowserWindowController.m
> +    ${MINIBROWSER_DIR}/ExtensionManagerWindowController.m
> +    ${MINIBROWSER_DIR}/main.m
> +    ${MINIBROWSER_DIR}/SettingsController.m
> +    ${MINIBROWSER_DIR}/WK1BrowserWindowController.m
> +    ${MINIBROWSER_DIR}/WK2BrowserWindowController.m

Please sort these entries according to the UNIX sort command.
Comment 3 Alex Christensen 2016-04-12 00:19:37 PDT 
Committed with a FIXME for the WEBCORE_EXPORT to http://trac.webkit.org/changeset/199338