Summary: | Merge AttributedDOMTokenList into DOMTokenList | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||
Component: | DOM | Assignee: | Chris Dumez <cdumez> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | rniwa | ||||
Priority: | P2 | ||||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Chris Dumez
2016-04-11 10:48:12 PDT
Created attachment 276157 [details]
Patch
Comment on attachment 276157 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=276157&action=review > Source/WebCore/html/DOMTokenList.cpp:203 > + // Do not reset the DOMTokenList value if the attribute value was changed by us. Why don't we assert that m_element is non-null. > Source/WebCore/html/DOMTokenList.cpp:212 > + m_cachedValue = nullAtom; Ditto. Comment on attachment 276157 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=276157&action=review >> Source/WebCore/html/DOMTokenList.cpp:203 >> + // Do not reset the DOMTokenList value if the attribute value was changed by us. > > Why don't we assert that m_element is non-null. because m_element is a reference? Sorry, I meant to say attributeName. (In reply to comment #4) > Sorry, I meant to say attributeName. attributeName is passed to the constructor and is a QualifiedName, stored as m_attributeName. Oh sorry, I misread your patch. I thought we had two constructors but we don't. Comment on attachment 276157 [details] Patch Clearing flags on attachment: 276157 Committed r199298: <http://trac.webkit.org/changeset/199298> All reviewed patches have been landed. Closing bug. |