Bug 156460

Summary:

[CMake] Make FOLDER property INHERITED

Product:

WebKit

Reporter:

Fujii Hironori <Hironori.Fujii>

Component:

WebKit Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, benjamin, bfulgham, commit-queue, ossy, thorton

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=83571

Attachments:

Description	Flags
Patch	none
screen shot of before	none
screen shot of after	none
Patch	none

Fujii Hironori

Reported 2016-04-10 19:26:41 PDT

The FOLDER property is set to some CMake targets to structure the generated Visual Studio solutions. (Bug 83571) But, some targets are not set the FOLDER property and generated project are in top folder in the solution. Making FOLDER property INHERITED is the easy way to set the proeprty to all targets under a directory. https://cmake.org/cmake/help/latest/command/define_property.html

Attachments
Patch (21.05 KB, patch) 2016-04-10 19:48 PDT, Fujii Hironori	no flags	Details Formatted Diff Diff
screen shot of before (45.78 KB, image/png) 2016-04-10 19:49 PDT, Fujii Hironori	no flags	Details
screen shot of after (44.82 KB, image/png) 2016-04-10 19:49 PDT, Fujii Hironori	no flags	Details
Patch (21.13 KB, patch) 2016-04-10 23:22 PDT, Fujii Hironori	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Fujii Hironori

Comment 1 2016-04-10 19:48:40 PDT

Created attachment 276120 [details] Patch

Fujii Hironori

Comment 2 2016-04-10 19:49:28 PDT

Created attachment 276121 [details] screen shot of before

Fujii Hironori

Comment 3 2016-04-10 19:49:46 PDT

Created attachment 276122 [details] screen shot of after

Brent Fulgham

Comment 4 2016-04-10 23:00:10 PDT

Comment on attachment 276120 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=276120&action=review Thank you for this fix! I found a couple of minor errors in the ChangeLog. If you fix them, we can land the change. > ChangeLog:8 > + Some CMake targets are not set the FOLDER property and Some CMake targets are not setting the FOLDER property. This causes the > ChangeLog:9 > + generated projects are in the top folder in the solution. generated projects to be displayed in the top-level folder of the solution. > ChangeLog:11 > + Making FOLDER property INHERITED is the easy way to set the Making the FOLDER property INHERITED ensures that all the targets > ChangeLog:12 > + proeprty to all targets under a directory. are placed in their proper directories.

Fujii Hironori

Comment 5 2016-04-10 23:22:19 PDT

Created attachment 276129 [details] Patch Thank you for reviewing my patch.

Brent Fulgham

Comment 6 2016-04-10 23:37:49 PDT

Comment on attachment 276129 [details] Patch Thank you so much for this patch! r=me.

WebKit Commit Bot

Comment 7 2016-04-11 00:28:39 PDT

Comment on attachment 276129 [details] Patch Clearing flags on attachment: 276129 Committed r199289: <http://trac.webkit.org/changeset/199289>

WebKit Commit Bot

Comment 8 2016-04-11 00:28:44 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.