Bug 156453

Summary: DOMTokenList.contains() should not throw
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: BindingsAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, darin, esprehn+autocc, gyuyoung.kim, kondapallykalyan, rniwa, sam
Priority: P2 Keywords: WebExposed
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
URL: https://github.com/whatwg/dom/commit/6d3076e3cbcba662489b272a718bc6b8c0082a74
Attachments:
Description Flags
Patch rniwa: review+

Description Chris Dumez 2016-04-10 13:44:00 PDT
DOMTokenList.contains() should not throw if the input token is invalid:
https://github.com/whatwg/dom/commit/6d3076e3cbcba662489b272a718bc6b8c0082a74
Comment 1 Chris Dumez 2016-04-10 14:07:12 PDT
First updating web-platform-tests via:
https://github.com/w3c/web-platform-tests/pull/2809
Comment 2 Chris Dumez 2016-04-10 14:12:50 PDT
Created attachment 276107 [details]
Patch
Comment 3 Ryosuke Niwa 2016-04-11 09:46:52 PDT
Comment on attachment 276107 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=276107&action=review

> LayoutTests/imported/w3c/ChangeLog:8
> +        Re-sync dom/nodes/Element-classlist.html with upstream.

Could you add the git hash to which you're synced?
Comment 4 Chris Dumez 2016-04-11 09:50:39 PDT
Committed r199296: <http://trac.webkit.org/changeset/199296>