Bug 156441

Summary: [Tools] correctly check for braces in multiline branches in macro definition
Product: WebKit Reporter: Caitlin Potter (:caitp) <caitp>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: aestes, bfulgham, commit-queue, darin, dbates, ddkilzer, glenn, lforschler
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Caitlin Potter (:caitp)
Reported 2016-04-09 13:29:10 PDT
[Tools] correctly check for braces in multiline branches in macro definition
Attachments
Patch (3.48 KB, patch)
2016-04-09 13:31 PDT, Caitlin Potter (:caitp) 		no flags
DetailsFormatted DiffDiff
Patch (3.48 KB, patch)
2016-04-09 13:32 PDT, Caitlin Potter (:caitp) 		no flags
DetailsFormatted DiffDiff
Patch (3.06 KB, patch)
2016-04-09 14:15 PDT, Caitlin Potter (:caitp) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Caitlin Potter (:caitp)
Comment 1 2016-04-09 13:31:15 PDT
Created attachment 276092 [details] Patch
Caitlin Potter (:caitp)
Comment 2 2016-04-09 13:32:46 PDT
Created attachment 276094 [details] Patch
Caitlin Potter (:caitp)
Comment 3 2016-04-09 13:33:41 PDT
Meant to fix a false positive reported in https://bugs.webkit.org/show_bug.cgi?id=156147#c46
Caitlin Potter (:caitp)
Comment 4 2016-04-09 14:15:54 PDT
Created attachment 276096 [details] Patch simplify a bit
WebKit Commit Bot
Comment 5 2016-04-10 17:10:14 PDT
Comment on attachment 276096 [details] Patch Clearing flags on attachment: 276096 Committed r199288: <http://trac.webkit.org/changeset/199288>
WebKit Commit Bot
Comment 6 2016-04-10 17:10:18 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.