Bug 156441 - [Tools] correctly check for braces in multiline branches in macro definition
Summary: [Tools] correctly check for braces in multiline branches in macro definition
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-04-09 13:29 PDT by Caitlin Potter (:caitp)
Modified: 2016-04-10 17:10 PDT (History)
8 users (show)

See Also:

Attachments
Patch (3.48 KB, patch)
2016-04-09 13:31 PDT, Caitlin Potter (:caitp) 		no flags Details | Formatted Diff | Diff
Patch (3.48 KB, patch)
2016-04-09 13:32 PDT, Caitlin Potter (:caitp) 		no flags Details | Formatted Diff | Diff
Patch (3.06 KB, patch)
2016-04-09 14:15 PDT, Caitlin Potter (:caitp) 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Caitlin Potter (:caitp) 2016-04-09 13:29:10 PDT 
[Tools] correctly check for braces in multiline branches in macro definition
Comment 1 Caitlin Potter (:caitp) 2016-04-09 13:31:15 PDT 
Created attachment 276092 [details]
Patch
Comment 2 Caitlin Potter (:caitp) 2016-04-09 13:32:46 PDT 
Created attachment 276094 [details]
Patch
Comment 3 Caitlin Potter (:caitp) 2016-04-09 13:33:41 PDT 
Meant to fix a false positive reported in https://bugs.webkit.org/show_bug.cgi?id=156147#c46
Comment 4 Caitlin Potter (:caitp) 2016-04-09 14:15:54 PDT 
Created attachment 276096 [details]
Patch

simplify a bit
Comment 5 WebKit Commit Bot 2016-04-10 17:10:14 PDT 
Comment on attachment 276096 [details]
Patch

Clearing flags on attachment: 276096

Committed r199288: <http://trac.webkit.org/changeset/199288>
Comment 6 WebKit Commit Bot 2016-04-10 17:10:18 PDT 
All reviewed patches have been landed.  Closing bug.