Bug 156427

Summary:

Escape builder names in url* and pathFor* methods of BuildbotSyncer

Product:

WebKit

Reporter:

Ryosuke Niwa <rniwa>

Component:

Perf Dashboard

Assignee:

Ryosuke Niwa <rniwa>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, dewei_zhu, rniwa, slewis

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Fixes the bug	none
Fixed one more bug	darin: review+

Ryosuke Niwa

Reported 2016-04-08 16:41:18 PDT

Turns out that my build fix in http://trac.webkit.org/changeset/199251 breaks other usage of RemoteAPI. Fix it properly by escaping builder names in BuildbotSyncer's methods.

Attachments
Fixes the bug (29.75 KB, patch) 2016-04-08 16:46 PDT, Ryosuke Niwa	no flags	Details Formatted Diff Diff
Fixed one more bug (34.71 KB, patch) 2016-04-08 20:02 PDT, Ryosuke Niwa	darin: review+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Ryosuke Niwa

Comment 1 2016-04-08 16:46:59 PDT

Created attachment 276053 [details] Fixes the bug

Ryosuke Niwa

Comment 2 2016-04-08 20:02:26 PDT

Created attachment 276075 [details] Fixed one more bug

Ryosuke Niwa

Comment 3 2016-04-08 21:55:46 PDT

Thanks for the reviews!

Ryosuke Niwa

Comment 4 2016-04-08 21:56:38 PDT

Committed r199266: <http://trac.webkit.org/changeset/199266>

Note You need to log in before you can comment on or make changes to this bug.