Bug 156424

Summary:

Web Inspector: primitive InspectorValue casts should use Optional<T> and templates

Product:

WebKit

Reporter:

Blaze Burg <bburg>

Component:

Web Inspector

Assignee:

Blaze Burg <bburg>

Status:

NEW

Severity:

Normal

CC:

buildbot, commit-queue, graouts, inspector-bugzilla-changes, keith_miller, mark.lam, msaboff, rniwa, saam, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Bug Depends on:

156407

Bug Blocks:

147067

Attachments:

Description	Flags
Proposed Fix	bburg: review-, bburg: commit-queue-
Archive of layout-test-results from ews116 for mac-yosemite	none
Archive of layout-test-results from ews102 for mac-yosemite	none
Archive of layout-test-results from ews106 for mac-yosemite-wk2	none

Blaze Burg

Reported 2016-04-08 16:20:13 PDT

Attachments
Proposed Fix (38.25 KB, patch) 2016-04-08 16:51 PDT, Blaze Burg	bburg: review- bburg: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews116 for mac-yosemite (878.09 KB, application/zip) 2016-04-08 17:23 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews102 for mac-yosemite (962.72 KB, application/zip) 2016-04-08 17:28 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews106 for mac-yosemite-wk2 (911.63 KB, application/zip) 2016-04-08 17:32 PDT, Build Bot	no flags	Details
View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2016-04-08 16:21:13 PDT

<rdar://problem/25636479>

Blaze Burg

Comment 2 2016-04-08 16:51:36 PDT

Created attachment 276054 [details] Proposed Fix

Blaze Burg

Comment 3 2016-04-08 16:52:12 PDT

Comment on attachment 276054 [details] Proposed Fix Needs to land with corresponding internal change.

WebKit Commit Bot

Comment 4 2016-04-08 16:52:32 PDT

This patch modifies the inspector protocol generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-inspector-generator-tests --reset-results`)

Build Bot

Comment 5 2016-04-08 17:23:23 PDT

Comment on attachment 276054 [details] Proposed Fix Attachment 276054 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/1122964 Number of test failures exceeded the failure limit.

Build Bot

Comment 6 2016-04-08 17:23:26 PDT

Created attachment 276063 [details] Archive of layout-test-results from ews116 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews116 Port: mac-yosemite Platform: Mac OS X 10.10.5

Build Bot

Comment 7 2016-04-08 17:28:21 PDT

Comment on attachment 276054 [details] Proposed Fix Attachment 276054 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/1123000 Number of test failures exceeded the failure limit.

Build Bot

Comment 8 2016-04-08 17:28:24 PDT

Created attachment 276064 [details] Archive of layout-test-results from ews102 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-yosemite Platform: Mac OS X 10.10.5

Build Bot

Comment 9 2016-04-08 17:32:46 PDT

Comment on attachment 276054 [details] Proposed Fix Attachment 276054 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/1123003 Number of test failures exceeded the failure limit.

Build Bot

Comment 10 2016-04-08 17:32:49 PDT

Created attachment 276065 [details] Archive of layout-test-results from ews106 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5

Blaze Burg

Comment 11 2016-04-11 11:23:18 PDT

Comment on attachment 276054 [details] Proposed Fix Clearing r? since dependent bug was rolled out.

Note You need to log in before you can comment on or make changes to this bug.