Bug 156407

Summary:

Web Inspector: get rid of InspectorBasicValue and InspectorString subclasses

Product:

WebKit

Reporter:

Blaze Burg <bburg>

Component:

Web Inspector

Assignee:

Blaze Burg <bburg>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bburg, commit-queue, graouts, joepeck, keith_miller, mark.lam, mattbaker, msaboff, nvasilyev, saam, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Bug Depends on:

156442

Bug Blocks:

156424

Attachments:

Description	Flags
Proposed Fix	none
Proposed Fix (v2)	joepeck: review+, bburg: commit-queue-

Blaze Burg

Reported 2016-04-08 10:29:42 PDT

They don't do anything helpful, and actively prevent code sharing/cleanup.

Attachments
Proposed Fix (25.71 KB, patch) 2016-04-08 10:42 PDT, Blaze Burg	no flags	Details Formatted Diff Diff
Proposed Fix (v2) (32.88 KB, patch) 2016-04-11 13:49 PDT, Blaze Burg	joepeck: review+ bburg: commit-queue-	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2016-04-08 10:30:36 PDT

<rdar://problem/25627659>

Blaze Burg

Comment 2 2016-04-08 10:42:09 PDT

Created attachment 276011 [details] Proposed Fix

WebKit Commit Bot

Comment 3 2016-04-08 12:59:25 PDT

Comment on attachment 276011 [details] Proposed Fix Clearing flags on attachment: 276011 Committed r199242: <http://trac.webkit.org/changeset/199242>

WebKit Commit Bot

Comment 4 2016-04-08 12:59:29 PDT

All reviewed patches have been landed. Closing bug.

Alexey Proskuryakov

Comment 5 2016-04-09 13:28:39 PDT

r199242 introduced a large number of leaks on the bots. Will try to roll out now. Apr 08 14:17 199246 failure #4343 Failed 112636 total leaks found for a total of 15,171,488 bytes. 460 unique leaks found. 2 failures 9 new passes Apr 08 13:56 199245 failure #4342 Failed 110033 total leaks found for a total of 23,142,368 bytes. 425 unique leaks found. 9 new passes Apr 08 13:30 199242 failure #4341 Failed 114409 total leaks found for a total of 282,429,440 bytes. 423 unique leaks found. 1 failures 9 new passes Apr 08 13:08 199241 failure #4340 Failed 6828 total leaks found for a total of 2,673,520 bytes. 207 unique leaks found. 2 failures 9 new passes Apr 08 12:46 199240 failure #4339 Failed 5586 total leaks found for a total of 1,496,480 bytes. 129 unique leaks found. 13 failures 9 new passes Apr 08 12:08 199237 failure #4338 Failed 5708 total leaks found for a total of 732,912 bytes. 201 unique leaks found. 2 failures 9 new passes Apr 08 11:48 199238 failure #4337 Failed 4781 total leaks found for a total of 2,272,064 bytes. 162 unique leaks found. 1 failures 9 new passes Leaks output seems too large to load in the browser, but individual leaks files can be seen here: <https://build.webkit.org/results/Apple%20El%20Capitan%20(Leaks)/r199268%20(4353)/>.

WebKit Commit Bot

Comment 6 2016-04-09 13:31:13 PDT

Re-opened since this is blocked by bug 156442

Blaze Burg

Comment 7 2016-04-09 20:40:16 PDT

The correct way to implement this can be copied from NodeOrString.h

Blaze Burg

Comment 8 2016-04-11 13:49:51 PDT

Created attachment 276172 [details] Proposed Fix (v2)

Blaze Burg

Comment 9 2016-04-11 13:50:12 PDT

Comment on attachment 276172 [details] Proposed Fix (v2) Needs to land with corresponding internal change.

Joseph Pecoraro

Comment 10 2016-04-11 14:00:31 PDT

Comment on attachment 276172 [details] Proposed Fix (v2) r=me

Blaze Burg

Comment 11 2016-04-11 16:22:11 PDT

Committed r199320: <http://trac.webkit.org/changeset/199320>

Note You need to log in before you can comment on or make changes to this bug.