| Summary: | Web Inspector: get rid of InspectorBasicValue and InspectorString subclasses | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | BJ Burg <bburg> | ||||||
| Component: | Web Inspector | Assignee: | BJ Burg <bburg> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | bburg, commit-queue, graouts, joepeck, keith_miller, mark.lam, mattbaker, msaboff, nvasilyev, saam, timothy, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | All | ||||||||
| OS: | All | ||||||||
| Bug Depends on: | 156442 | ||||||||
| Bug Blocks: | 156424 | ||||||||
| Attachments: |
|
||||||||
|
Description
BJ Burg
2016-04-08 10:29:42 PDT
Created attachment 276011 [details]
Proposed Fix
Comment on attachment 276011 [details] Proposed Fix Clearing flags on attachment: 276011 Committed r199242: <http://trac.webkit.org/changeset/199242> All reviewed patches have been landed. Closing bug. r199242 introduced a large number of leaks on the bots. Will try to roll out now. Apr 08 14:17 199246 failure #4343 Failed 112636 total leaks found for a total of 15,171,488 bytes. 460 unique leaks found. 2 failures 9 new passes Apr 08 13:56 199245 failure #4342 Failed 110033 total leaks found for a total of 23,142,368 bytes. 425 unique leaks found. 9 new passes Apr 08 13:30 199242 failure #4341 Failed 114409 total leaks found for a total of 282,429,440 bytes. 423 unique leaks found. 1 failures 9 new passes Apr 08 13:08 199241 failure #4340 Failed 6828 total leaks found for a total of 2,673,520 bytes. 207 unique leaks found. 2 failures 9 new passes Apr 08 12:46 199240 failure #4339 Failed 5586 total leaks found for a total of 1,496,480 bytes. 129 unique leaks found. 13 failures 9 new passes Apr 08 12:08 199237 failure #4338 Failed 5708 total leaks found for a total of 732,912 bytes. 201 unique leaks found. 2 failures 9 new passes Apr 08 11:48 199238 failure #4337 Failed 4781 total leaks found for a total of 2,272,064 bytes. 162 unique leaks found. 1 failures 9 new passes Leaks output seems too large to load in the browser, but individual leaks files can be seen here: <https://build.webkit.org/results/Apple%20El%20Capitan%20(Leaks)/r199268%20(4353)/>. Re-opened since this is blocked by bug 156442 The correct way to implement this can be copied from NodeOrString.h Created attachment 276172 [details]
Proposed Fix (v2)
Comment on attachment 276172 [details]
Proposed Fix (v2)
Needs to land with corresponding internal change.
Comment on attachment 276172 [details]
Proposed Fix (v2)
r=me
Committed r199320: <http://trac.webkit.org/changeset/199320> |