| Summary: | [iOS WK2] Stop using exposedContentRect for history scroll state restoration | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||
| Component: | New Bugs | Assignee: | Simon Fraser (smfr) <simon.fraser> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | bdakin, cdumez, commit-queue, japhet, simon.fraser, thorton | ||||
| Priority: | P2 | ||||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Simon Fraser (smfr)
2016-04-07 21:12:12 PDT
Created attachment 275978 [details]
Patch
Attachment 275978 [details] did not pass style-queue:
ERROR: Source/WebKit2/Shared/VisibleContentRectUpdateInfo.h:50: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4]
Total errors found: 1 in 19 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 275978 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=275978&action=review > Source/WebCore/history/HistoryItem.h:271 > + FloatSize m_obscuredInset; It seems somewhat weird that you are only saving 1/2 of the values of the obscured inset. I realize those are the ones you need, but it still seems weird. |