Bug 156384

Summary:

Remove ENABLE(ENABLE_ES6_CLASS_SYNTAX) guards

Product:

WebKit

Reporter:

Joseph Pecoraro <joepeck>

Component:

WebKit Misc.

Assignee:

Joseph Pecoraro <joepeck>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, joepeck, keith_miller, rniwa, saam, ysuzuki

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
[PATCH] Proposed Fix - Unskip	rniwa: review+, rniwa: commit-queue+
[PATCH] Proposed Fix	rniwa: review+
[PATCH] For Landing	none

Description Joseph Pecoraro 2016-04-07 20:16:54 PDT

Remove ENABLE(ENABLE_ES6_CLASS_SYNTAX) guards.

All tests pass. We've had the feature enabled by default for over a year. Multiple WebKit browser releases have included the feature enabled.

Should we also update the features.json status to "Done", or are there parts (native subclassing) that are still considered "In Development"?

Comment 1 Joseph Pecoraro 2016-04-07 20:19:59 PDT

Created attachment 275969 [details]
[PATCH] Proposed Fix - Unskip

Comment 2 WebKit Commit Bot 2016-04-07 20:20:56 PDT

Attachment 275969 [details] did not pass style-queue:


ERROR: Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig:0:  Patch introduces a new FeatureDefines.xcconfig, which check-webkit-style doesn't know about. Please add it to the list in featuredefines.py.  [featuredefines/new] [5]
Total errors found: 1 in 14 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 Joseph Pecoraro 2016-04-07 20:22:47 PDT

Created attachment 275970 [details]
[PATCH] Proposed Fix

Comment 4 Joseph Pecoraro 2016-04-07 20:23:24 PDT

Comment on attachment 275970 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=275970&action=review

> Source/JavaScriptCore/ChangeLog:4
> +        Remove ENABLE(ENABLE_ES6_CLASS_SYNTAX) guards
> +        https://bugs.webkit.org/show_bug.cgi?id=156384

Thoughts on marking the feature "Done" in JavaScriptCore/features.json?

Comment 5 WebKit Commit Bot 2016-04-07 20:23:31 PDT

Attachment 275970 [details] did not pass style-queue:


ERROR: Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig:0:  Patch introduces a new FeatureDefines.xcconfig, which check-webkit-style doesn't know about. Please add it to the list in featuredefines.py.  [featuredefines/new] [5]
Total errors found: 1 in 14 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 6 Ryosuke Niwa 2016-04-07 20:24:19 PDT

Comment on attachment 275970 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=275970&action=review

>> Source/JavaScriptCore/ChangeLog:4
>> +        https://bugs.webkit.org/show_bug.cgi?id=156384
> 
> Thoughts on marking the feature "Done" in JavaScriptCore/features.json?

I think we can make it as done now.

Comment 7 Joseph Pecoraro 2016-04-07 20:27:18 PDT

Created attachment 275971 [details]
[PATCH] For Landing

Comment 8 WebKit Commit Bot 2016-04-07 20:28:15 PDT

Attachment 275971 [details] did not pass style-queue:


ERROR: Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig:0:  Patch introduces a new FeatureDefines.xcconfig, which check-webkit-style doesn't know about. Please add it to the list in featuredefines.py.  [featuredefines/new] [5]
Total errors found: 1 in 15 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 9 Keith Miller 2016-04-07 20:45:32 PDT

> >> Source/JavaScriptCore/ChangeLog:4
> >> +        https://bugs.webkit.org/show_bug.cgi?id=156384
> > 
> > Thoughts on marking the feature "Done" in JavaScriptCore/features.json?
> 
> I think we can make it as done now.

If there is anything wrong with our class implementation it's a bug and not a lack of feature work.

Comment 10 WebKit Commit Bot 2016-04-07 21:17:24 PDT

Comment on attachment 275971 [details]
[PATCH] For Landing

Clearing flags on attachment: 275971

Committed r199214: <http://trac.webkit.org/changeset/199214>