Bug 156339

Summary: FrameView::qualifiesAsVisuallyNonEmpty() returns false when loading a Google search results page before search results are loaded, even though the header is visible
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, commit-queue, jeffm, kling, sam, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch none

Antti Koivisto
Reported 2016-04-07 05:16:59 PDT
FrameView::qualifiesAsVisuallyNonEmpty() returns false when loading a Google search results page before search results are loaded, even though the header at the top of the page has been rendered. Google's current design shows a 60 pixel high header almost instantly, with the actual search results coming in later.
Attachments
patch (1.71 KB, patch)
2016-04-07 05:22 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2016-04-07 05:17:37 PDT
<rdar://problem/24491381>
Antti Koivisto
Comment 2 2016-04-07 05:22:58 PDT
Created attachment 275884 [details] patch
Andreas Kling
Comment 3 2016-04-07 06:04:50 PDT
Comment on attachment 275884 [details] patch Sweet hax. r=me
WebKit Commit Bot
Comment 4 2016-04-07 07:22:13 PDT
Comment on attachment 275884 [details] patch Clearing flags on attachment: 275884 Committed r199155: <http://trac.webkit.org/changeset/199155>
WebKit Commit Bot
Comment 5 2016-04-07 07:22:18 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.