Bug 156337

Summary: S390X and PPC64 architectures detection is wrong
Product: WebKit Reporter: Tomas Popela <tpopela>
Component: Web Template FrameworkAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, cmarcelo, commit-queue, dbates
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Proposed patch
none
Proposed patch
none
Proposed patch none

Tomas Popela
Reported 2016-04-07 04:25:30 PDT
After the https://bugs.webkit.org/show_bug.cgi?id=156015 was committed it showed that the PPC64 detection is wrong as on the CPU(PPC) path was activated even for PPC64. The thing is that GCC defines __ppc__ even on PPC64 and not just on PPC(32). The same applies for S390X. $ gcc -dM -E - < /dev/null | grep PPC #define _ARCH_PPCGR 1 #define __PPC64__ 1 <--- #define _ARCH_PPCSQ 1 #define _ARCH_PPC 1 #define __PPC__ 1 <--- #define _ARCH_PPC64 1
Attachments
Proposed patch (2.48 KB, patch)
2016-04-07 04:28 PDT, Tomas Popela 		no flags
DetailsFormatted DiffDiff
Proposed patch (3.49 KB, patch)
2016-04-07 05:16 PDT, Tomas Popela 		no flags
DetailsFormatted DiffDiff
Proposed patch (2.48 KB, patch)
2016-04-07 05:27 PDT, Tomas Popela 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Tomas Popela
Comment 1 2016-04-07 04:28:33 PDT
Created attachment 275880 [details] Proposed patch
Carlos Garcia Campos
Comment 2 2016-04-07 05:00:21 PDT
Comment on attachment 275880 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=275880&action=review > Source/WTF/ChangeLog:8 > + After the https://bugs.webkit.org/show_bug.cgi?id=156015 was committed Please, use the revision number here instead of (or in addition to) the bug. I usually grep rev numbers to see commits fixing regressions introduced in other commits, or follow ups, etc. It makes my life easier :-)
Tomas Popela
Comment 3 2016-04-07 05:16:56 PDT
Created attachment 275883 [details] Proposed patch
Tomas Popela
Comment 4 2016-04-07 05:27:35 PDT
Created attachment 275885 [details] Proposed patch
WebKit Commit Bot
Comment 5 2016-04-12 09:44:30 PDT
Comment on attachment 275885 [details] Proposed patch Clearing flags on attachment: 275885 Committed r199366: <http://trac.webkit.org/changeset/199366>
WebKit Commit Bot
Comment 6 2016-04-12 09:44:35 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.