Bug 156319

Summary: Web Automation: implement Automation.addSingleCookie
Product: WebKit Reporter: Blaze Burg <bburg>
Component: Web InspectorAssignee: Blaze Burg <bburg>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on: 156091    
Bug Blocks: 156345    
Attachments:
Description Flags
Proposed Fix
none
For EWS darin: review+

Blaze Burg
Reported 2016-04-06 16:48:09 PDT
.
Attachments
Proposed Fix (12.59 KB, patch)
2016-04-06 16:52 PDT, Blaze Burg 		no flags
DetailsFormatted DiffDiff
For EWS (12.23 KB, patch)
2016-04-07 14:49 PDT, Blaze Burg 		darin: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2016-04-06 16:48:25 PDT
<rdar://problem/25589605>
Blaze Burg
Comment 2 2016-04-06 16:52:55 PDT
Created attachment 275832 [details] Proposed Fix
Blaze Burg
Comment 3 2016-04-07 14:49:17 PDT
Created attachment 275941 [details] For EWS
Blaze Burg
Comment 4 2016-04-07 15:34:59 PDT
Committed r199197: <http://trac.webkit.org/changeset/199197>
Darin Adler
Comment 5 2016-04-16 10:47:19 PDT
Comment on attachment 275941 [details] For EWS View in context: https://bugs.webkit.org/attachment.cgi?id=275941&action=review > Source/WebKit2/UIProcess/Automation/WebAutomationSession.cpp:754 > + WebCore::URL activeURL = WebCore::URL(WebCore::URL(), page->pageLoadState().activeURL()); I suggest writing this in a way where WebCore::URL is not repeated as much. Either with auto, or just as a declaration without the "=". > Source/WebKit2/UIProcess/Automation/WebAutomationSession.cpp:755 > + ASSERT(activeURL.isValid()); Why is this a valid assertion? Is there some guarantee? > Source/WebKit2/UIProcess/Automation/WebAutomationSession.cpp:759 > + if (!cookieObject.getString(WTF::ASCIILiteral("name"), cookie.name)) WTF prefix here is unneeded. > Source/WebKit2/UIProcess/Automation/WebAutomationSession.cpp:782 > + cookie.expires = expires * 1000.0; No need for the ".0" here. > Source/WebKit2/UIProcess/Automation/WebAutomationSession.cpp:794 > + WebCookieManagerProxy* cookieManager = m_processPool->supplement<WebCookieManagerProxy>(); > + cookieManager->addCookie(cookie, activeURL.host()); I suggest writing this on a single line.
Note You need to log in before you can comment on or make changes to this bug.