Bug 156318

Summary: String.prototype.match() should be calling internal function RegExpCreate.
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, fpizlo, ggaren, keith_miller, msaboff, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch. fpizlo: review+

Mark Lam
Reported 2016-04-06 16:44:45 PDT
Note: RegExpCreate is not the same as the RegExp constructor. The current implementation does a new @RegExp. This results in a failure in es6/Proxy_internal_get_calls_String.prototype.match.js, and possibly es6/Proxy_internal_get_calls_String.prototype.search.js as well.
Attachments
proposed patch. (8.06 KB, patch)
2016-04-06 19:21 PDT, Mark Lam 		fpizlo: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2016-04-06 16:45:49 PDT
<rdar://problem/25589543>
Radar WebKit Bug Importer
Comment 2 2016-04-06 16:46:07 PDT
<rdar://problem/25589550>
Mark Lam
Comment 3 2016-04-06 19:21:42 PDT
Created attachment 275848 [details] proposed patch. Currently running tests. Will wait for tests before landing.
Mark Lam
Comment 4 2016-04-06 20:19:04 PDT
Thanks for the review. Tests are passing. Landed in r199144: <http://trac.webkit.org/r199144>.
Note You need to log in before you can comment on or make changes to this bug.