Bug 156318

Summary: String.prototype.match() should be calling internal function RegExpCreate.
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, fpizlo, ggaren, keith_miller, msaboff, sbarati, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch. fpizlo: review+

Description Mark Lam 2016-04-06 16:44:45 PDT
Note: RegExpCreate is not the same as the RegExp constructor.  The current implementation does a new @RegExp.  This results in a failure in es6/Proxy_internal_get_calls_String.prototype.match.js, and possibly es6/Proxy_internal_get_calls_String.prototype.search.js as well.
Comment 1 Radar WebKit Bug Importer 2016-04-06 16:45:49 PDT
<rdar://problem/25589543>
Comment 2 Radar WebKit Bug Importer 2016-04-06 16:46:07 PDT
<rdar://problem/25589550>
Comment 3 Mark Lam 2016-04-06 19:21:42 PDT
Created attachment 275848 [details]
proposed patch.

Currently running tests.  Will wait for tests before landing.
Comment 4 Mark Lam 2016-04-06 20:19:04 PDT
Thanks for the review.  Tests are passing.  Landed in r199144: <http://trac.webkit.org/r199144>.