WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
156318
String.prototype.match() should be calling internal function RegExpCreate.
https://bugs.webkit.org/show_bug.cgi?id=156318
Summary
String.prototype.match() should be calling internal function RegExpCreate.
Mark Lam
Reported
2016-04-06 16:44:45 PDT
Note: RegExpCreate is not the same as the RegExp constructor. The current implementation does a new @RegExp. This results in a failure in es6/Proxy_internal_get_calls_String.prototype.match.js, and possibly es6/Proxy_internal_get_calls_String.prototype.search.js as well.
Attachments
proposed patch.
(8.06 KB, patch)
2016-04-06 19:21 PDT
,
Mark Lam
fpizlo
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2016-04-06 16:45:49 PDT
<
rdar://problem/25589543
>
Radar WebKit Bug Importer
Comment 2
2016-04-06 16:46:07 PDT
<
rdar://problem/25589550
>
Mark Lam
Comment 3
2016-04-06 19:21:42 PDT
Created
attachment 275848
[details]
proposed patch. Currently running tests. Will wait for tests before landing.
Mark Lam
Comment 4
2016-04-06 20:19:04 PDT
Thanks for the review. Tests are passing. Landed in
r199144
: <
http://trac.webkit.org/r199144
>.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug