Bug 156318 - String.prototype.match() should be calling internal function RegExpCreate.
Summary: String.prototype.match() should be calling internal function RegExpCreate.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-04-06 16:44 PDT by Mark Lam
Modified: 2016-04-06 20:19 PDT (History)
7 users (show)

See Also:


Attachments
proposed patch. (8.06 KB, patch)
2016-04-06 19:21 PDT, Mark Lam
fpizlo: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2016-04-06 16:44:45 PDT
Note: RegExpCreate is not the same as the RegExp constructor.  The current implementation does a new @RegExp.  This results in a failure in es6/Proxy_internal_get_calls_String.prototype.match.js, and possibly es6/Proxy_internal_get_calls_String.prototype.search.js as well.
Comment 1 Radar WebKit Bug Importer 2016-04-06 16:45:49 PDT
<rdar://problem/25589543>
Comment 2 Radar WebKit Bug Importer 2016-04-06 16:46:07 PDT
<rdar://problem/25589550>
Comment 3 Mark Lam 2016-04-06 19:21:42 PDT
Created attachment 275848 [details]
proposed patch.

Currently running tests.  Will wait for tests before landing.
Comment 4 Mark Lam 2016-04-06 20:19:04 PDT
Thanks for the review.  Tests are passing.  Landed in r199144: <http://trac.webkit.org/r199144>.