Bug 156309

Summary: JSC test stress/arrowfunction-lexical-bind-superproperty.js failing
Product: WebKit Reporter: Ryan Haddad <ryanhaddad>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, fpizlo, keith_miller, mark.lam, msaboff, saam
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=155598
Bug Depends on:    
Bug Blocks: 156998    
Attachments:
Description Flags
Crash log
none
the patch saam: review+

Description Ryan Haddad 2016-04-06 13:50:22 PDT 
JSC test stress/arrowfunction-lexical-bind-superproperty.js failing

stress/arrowfunction-lexical-bind-superproperty.js.dfg-maximal-flush-validate-no-cjit
stress/arrowfunction-lexical-bind-superproperty.js.ftl-no-cjit-no-put-stack-validate
stress/arrowfunction-lexical-bind-superproperty.js.ftl-no-cjit-validate-sampling-profiler
stress/arrowfunction-lexical-bind-superproperty.js.no-cjit-validate-phases

<https://build.webkit.org/builders/Apple%20El%20Capitan%20Release%20JSC%20%28Tests%29/builds/4829/steps/jscore-test/logs/stdio>
Comment 1 Keith Miller 2016-04-06 13:51:39 PDT 
Created attachment 275815 [details]
Crash log
Comment 2 Ryan Haddad 2016-04-06 13:52:32 PDT 
May be related to <https://trac.webkit.org/changeset/199076>
Comment 3 Filip Pizlo 2016-04-06 14:12:04 PDT 
Interesting.  I will fix.
Comment 4 Filip Pizlo 2016-04-06 14:37:34 PDT 
I have an elagant fix to this bug, but I don't know yet if it's perf-neutral.
Comment 5 Filip Pizlo 2016-04-06 14:38:04 PDT 
Oh, and the bug that this is revealing is a preexisting condition: our stack scanner assumes that callee/argumentCount are also valid while the compiler thinks otherwise.
Comment 6 Filip Pizlo 2016-04-06 16:41:59 PDT 
Created attachment 275830 [details]
the patch
Comment 7 Filip Pizlo 2016-04-06 18:12:15 PDT 
Landed in http://trac.webkit.org/changeset/199129
Comment 8 David Kilzer (:ddkilzer) 2016-04-22 12:59:30 PDT 
<rdar://problem/24894592>