Bug 156304

Summary: Rename MidpointState to WhitespaceCollapsingState
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: New BugsAssignee: Myles C. Maxfield <mmaxfield>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, commit-queue, esprehn+autocc, glenn, kondapallykalyan, rniwa
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
hyatt: review+, buildbot: commit-queue-
Archive of layout-test-results from ews106 for mac-yosemite-wk2
none
Archive of layout-test-results from ews125 for ios-simulator-wk2
none
Archive of layout-test-results from ews101 for mac-yosemite
none
Archive of layout-test-results from ews115 for mac-yosemite
none
Patch for committing none

Myles C. Maxfield
Reported 2016-04-06 12:00:50 PDT
Rename MidpointState to WhitespaceCollapsingState
Attachments
Patch (39.80 KB, patch)
2016-04-06 12:09 PDT, Myles C. Maxfield 		hyatt: review+
buildbot: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews106 for mac-yosemite-wk2 (872.78 KB, application/zip)
2016-04-06 12:41 PDT, Build Bot 		no flags
Details
Archive of layout-test-results from ews125 for ios-simulator-wk2 (532.97 KB, application/zip)
2016-04-06 12:48 PDT, Build Bot 		no flags
Details
Archive of layout-test-results from ews101 for mac-yosemite (451.43 KB, application/zip)
2016-04-06 12:50 PDT, Build Bot 		no flags
Details
Archive of layout-test-results from ews115 for mac-yosemite (353.38 KB, application/zip)
2016-04-06 13:00 PDT, Build Bot 		no flags
Details
Patch for committing (42.08 KB, patch)
2016-04-06 21:12 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1 2016-04-06 12:09:32 PDT
Created attachment 275804 [details] Patch
Build Bot
Comment 2 2016-04-06 12:41:29 PDT
Comment on attachment 275804 [details] Patch Attachment 275804 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/1110535 Number of test failures exceeded the failure limit.
Build Bot
Comment 3 2016-04-06 12:41:31 PDT
Created attachment 275809 [details] Archive of layout-test-results from ews106 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5
Build Bot
Comment 4 2016-04-06 12:48:06 PDT
Comment on attachment 275804 [details] Patch Attachment 275804 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/1110548 Number of test failures exceeded the failure limit.
Build Bot
Comment 5 2016-04-06 12:48:09 PDT
Created attachment 275811 [details] Archive of layout-test-results from ews125 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews125 Port: ios-simulator-wk2 Platform: Mac OS X 10.10.5
Build Bot
Comment 6 2016-04-06 12:50:49 PDT
Comment on attachment 275804 [details] Patch Attachment 275804 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/1110585 Number of test failures exceeded the failure limit.
Build Bot
Comment 7 2016-04-06 12:50:51 PDT
Created attachment 275812 [details] Archive of layout-test-results from ews101 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-yosemite Platform: Mac OS X 10.10.5
Build Bot
Comment 8 2016-04-06 12:59:57 PDT
Comment on attachment 275804 [details] Patch Attachment 275804 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/1110597 Number of test failures exceeded the failure limit.
Build Bot
Comment 9 2016-04-06 13:00:00 PDT
Created attachment 275813 [details] Archive of layout-test-results from ews115 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews115 Port: mac-yosemite Platform: Mac OS X 10.10.5
Dave Hyatt
Comment 10 2016-04-06 13:42:08 PDT
Comment on attachment 275804 [details] Patch r=me
Myles C. Maxfield
Comment 11 2016-04-06 20:08:21 PDT
Comment on attachment 275804 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=275804&action=review > Source/WebCore/platform/text/BidiResolver.h:59 > void ensureLineBoxInsideIgnoredSpaces(RenderObject* renderer) This should take a reference.
Myles C. Maxfield
Comment 12 2016-04-06 21:12:10 PDT
Created attachment 275861 [details] Patch for committing
Myles C. Maxfield
Comment 13 2016-04-06 21:59:57 PDT
Committed r199149: <http://trac.webkit.org/changeset/199149>
Note You need to log in before you can comment on or make changes to this bug.