| Summary: | Web Inspector: Do not create CodeMirror color/gradient markers in JavaScript resources | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Joseph Pecoraro <joepeck> | ||||
| Component: | Web Inspector | Assignee: | Joseph Pecoraro <joepeck> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | bburg, commit-queue, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Attachments: |
|
||||||
Created attachment 275751 [details]
[PATCH] Proposed Fix
Comment on attachment 275751 [details] [PATCH] Proposed Fix Clearing flags on attachment: 275751 Committed r199095: <http://trac.webkit.org/changeset/199095> All reviewed patches have been landed. Closing bug. *** Bug 129629 has been marked as a duplicate of this bug. *** |
* SUMMARY Do not create CodeMirror color/gradient markers in JavaScript resources. * TEST var red = "foo"; * STEPS TO REPRODUCE 1. Inspect test page 2. Show JavaScript resource with a variable name that is a CSS color name 3. Hover variable name => Get color marker * NOTES Performance is poor. Creating markers for JavaScript resources doesn't make sense either. Logging time it took to generate markers on the JavaScript resources on apple.com: MARKERS 43ms MARKERS 807ms MARKERS 58ms MARKERS 285ms MARKERS 824ms MARKERS 134ms This can be completely eliminated.