Bug 156277

Summary: Improve some other cases of context-sensitive inlining
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, keith_miller, mark.lam, msaboff, saam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
the patch benjamin: review+

Filip Pizlo
Reported 2016-04-05 20:55:00 PDT
I found some simple improvements in the bytecode parser that greatly improve the chances of context-sensitive inlining happening by revealing the callee constant.
Attachments
the patch (11.84 KB, patch)
2016-04-05 21:03 PDT, Filip Pizlo 		benjamin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2016-04-05 21:03:57 PDT
Created attachment 275744 [details] the patch
Benjamin Poulain
Comment 2 2016-04-05 21:14:52 PDT
Comment on attachment 275744 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=275744&action=review > Source/JavaScriptCore/ChangeLog:32 > + This is a 14% speed-up on Octane/raytrace. On one hand, optimizing at the parser level is pretty weird. On the other hand...14%! > Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:1176 > + return; You don't need the return.
Filip Pizlo
Comment 3 2016-04-05 21:46:39 PDT
Landed in http://trac.webkit.org/changeset/199093
Note You need to log in before you can comment on or make changes to this bug.