Bug 156268

Summary: Make CMake-generated binaries on Mac able to run
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: bshafiei, dbates, dburkart, matthew_hanson
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch dbates: review+

Description Alex Christensen 2016-04-05 17:39:12 PDT 
Make CMake-generated binaries on Mac able to run
Comment 1 Alex Christensen 2016-04-05 17:39:36 PDT 
Created attachment 275729 [details]
Patch
Comment 2 Alex Christensen 2016-04-05 18:05:43 PDT 
Created attachment 275734 [details]
Patch
Comment 3 Daniel Bates 2016-04-05 22:00:03 PDT 
Comment on attachment 275734 [details]
Patch

r=me
Comment 4 Alex Christensen 2016-04-05 22:32:21 PDT 
Committed to http://trac.webkit.org/changeset/199094 with one change from the patch: I hardcoded -compatibility_version 1 instead of ${WEBKIT_MAC_VERSION} because that is what Xcode does right now.
Comment 5 Alex Christensen 2016-04-05 22:36:24 PDT 
Next step: getting them to run without crashing.  Right now sizeof(WebCore::Page) is inconsistent, causing horrible crashes :(