Bug 156189

Summary: Make FrameView's exposedRect an Optional<>
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, kondapallykalyan
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Simon Fraser (smfr)
Reported 2016-04-04 16:56:20 PDT
Make FrameView's exposedRect an Optional<>
Attachments
Patch (5.75 KB, patch)
2016-04-04 16:57 PDT, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2016-04-04 16:57:17 PDT
Created attachment 275592 [details] Patch
Tim Horton
Comment 2 2016-04-04 16:58:08 PDT
Comment on attachment 275592 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=275592&action=review > Source/WebCore/rendering/RenderLayerCompositor.cpp:462 > + FloatRect visibleRect = m_clipLayer ? FloatRect({ 0, 0 }, frameView.unscaledVisibleContentSizeIncludingObscuredArea()) : frameView.visibleContentRect(); Technically I think you can get away without the 0, 0 but I don't know if you should.
WebKit Commit Bot
Comment 3 2016-04-04 21:04:40 PDT
Comment on attachment 275592 [details] Patch Clearing flags on attachment: 275592 Committed r199038: <http://trac.webkit.org/changeset/199038>
WebKit Commit Bot
Comment 4 2016-04-04 21:04:43 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.