Bug 156168

Summary: CopiedBlock should be 16kB
Product: WebKit Reporter: Geoffrey Garen <ggaren>
Component: New BugsAssignee: Geoffrey Garen <ggaren>
Status: RESOLVED INVALID    
Severity: Normal CC: barraclough, benjamin, commit-queue, keith_miller, kling, mark.lam, msaboff, saam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Geoffrey Garen
Reported 2016-04-04 09:23:26 PDT
CopiedBlock should be 16kB
Attachments
Patch (1.50 KB, patch)
2016-04-04 09:29 PDT, Geoffrey Garen 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Geoffrey Garen
Comment 1 2016-04-04 09:29:28 PDT
Created attachment 275551 [details] Patch
Mark Lam
Comment 2 2016-04-04 09:43:04 PDT
Comment on attachment 275551 [details] Patch r=me
Geoffrey Garen
Comment 3 2016-04-04 11:51:15 PDT
Comment on attachment 275551 [details] Patch cq+
WebKit Commit Bot
Comment 4 2016-04-04 12:41:32 PDT
Comment on attachment 275551 [details] Patch Clearing flags on attachment: 275551 Committed r199016: <http://trac.webkit.org/changeset/199016>
WebKit Commit Bot
Comment 5 2016-04-04 12:41:36 PDT
All reviewed patches have been landed. Closing bug.
Benjamin Poulain
Comment 6 2016-04-05 00:41:22 PDT
Something really curious happened with this: https://arewefastyet.com/#machine=29&view=single&suite=kraken&subtest=beat-detection Any idea how to get back this win without the other regressions?
Geoffrey Garen
Comment 7 2016-04-05 10:52:16 PDT
Rolled out in <http://trac.webkit.org/changeset/199032>. "Regressed Octane and Kraken on the perf bots."
Geoffrey Garen
Comment 8 2016-04-05 10:58:11 PDT
> Any idea how to get back this win without the other regressions? I might be able to bring it back. I didn't quite do it the best way the first time because I forgot to consider aligned allocation requests, which still take the slow path. I don't understand that graph though -- what does it say?
Geoffrey Garen
Comment 9 2016-04-06 19:08:17 PDT
Committed r199125: <http://trac.webkit.org/changeset/199125>
Geoffrey Garen
Comment 10 2016-04-06 20:33:46 PDT
Rolled out in <http://trac.webkit.org/changeset/199145>. "Perf bots are down, so I can't re-land this right now."
Geoffrey Garen
Comment 11 2016-04-06 23:41:31 PDT
On Octane, there's no regression. On Kraken: 1% speedup on Mac Pro 1% speedup on iPhone (+/- !%) 1% regression on MacBook Pro 1% regression on MacBook Air That's enough of a mixed review that I think I'll leave this alone for now.
Note You need to log in before you can comment on or make changes to this bug.