Bug 156164

Summary:

REGRESSION(r198492): [GTK] The WEB_RTC flag was not correctly added in some situations

Product:

WebKit

Reporter:

Alejandro G. Castro <alex>

Component:

WebKit Misc.

Assignee:

Alejandro G. Castro <alex>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

adam.bergkvist, andersca, commit-queue, eric.carlson, pnormand

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Alejandro G. Castro

Reported 2016-04-04 04:22:46 PDT

In that commit a new WEB_RTC flag was added but in some situations it was used WEBRTC, also it was not activated by default as expected. After that commit and because some idls were not compiled the commit r198833 did not add the required parameters in the webrtc idls, so we are going to fix also that.

Attachments
Patch (28.56 KB, patch) 2016-04-04 04:32 PDT, Alejandro G. Castro	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Alejandro G. Castro

Comment 1 2016-04-04 04:32:56 PDT

Created attachment 275544 [details] Patch

Eric Carlson

Comment 2 2016-04-04 06:54:43 PDT

Thanks for fixing this Alejandro!

Alejandro G. Castro

Comment 3 2016-04-04 08:23:13 PDT

(In reply to comment #2) > Thanks for fixing this Alejandro! You are welcome, thanks for your help with WebRTC.

WebKit Commit Bot

Comment 4 2016-04-04 09:12:39 PDT

Comment on attachment 275544 [details] Patch Clearing flags on attachment: 275544 Committed r199007: <http://trac.webkit.org/changeset/199007>

WebKit Commit Bot

Comment 5 2016-04-04 09:12:43 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.